Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non standard NXpositioner groups #205

Merged
merged 30 commits into from
May 10, 2024

Conversation

noemifrisina
Copy link
Collaborator

@noemifrisina noemifrisina commented Feb 29, 2024

First part of #195

This mid-way fix makes the non-standard groups optional and changes the NX_class from NXpositioner to NXtransformations

@noemifrisina noemifrisina added the NXmx New NXmx issue label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.04%. Comparing base (2a1593b) to head (ffa1050).
Report is 31 commits behind head on main.

❗ Current head ffa1050 differs from pull request most recent head 98ce56e. Consider uploading reports for the commit 98ce56e to get more accurate results

Files Patch % Lines
src/nexgen/nxs_write/NXclassWriters.py 90.62% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   43.87%   44.04%   +0.16%     
==========================================
  Files          45       45              
  Lines        3893     3860      -33     
  Branches      742      732      -10     
==========================================
- Hits         1708     1700       -8     
+ Misses       2058     2040      -18     
+ Partials      127      120       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noemifrisina noemifrisina merged commit edb2c45 into main May 10, 2024
12 checks passed
@noemifrisina noemifrisina deleted the remove-non-standard-NXpositioner branch May 10, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NXmx New NXmx issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant