Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Implement a plan to obtain parameters (including for ispyb) and further separate handlers #375

Closed
dperl-dls opened this issue Nov 18, 2022 · 4 comments
Labels
rotation scan Preparing for implementation of rotation scans

Comments

@dperl-dls
Copy link
Collaborator

We should have a plan to fetch whatever parameters we need (currently in parameters.py) from their respective PVs, both to run the gridscan and create the ispyb deposition, and then provide this info in the metadata of the gridscan plan, so that the zocalo handler on the main portion of the plan can simply listen and obtain the ispyb deposition numbers, and no longer need to be passed the ispyb handler; also removes ordering requirement for callback subscription

@dperl-dls dperl-dls self-assigned this Nov 21, 2022
@dperl-dls dperl-dls added the rotation scan Preparing for implementation of rotation scans label Nov 21, 2022
@dperl-dls
Copy link
Collaborator Author

should this be the same for any experiment type - i.e. read everything we need for grid or rotation scan? or separate plans which load just enough for each?
imo since eventually we want to: load parameters -> do grid scan -> do rotation scan, we should just have one

@DominicOram
Copy link
Collaborator

First step is to go through all the parameters that GDA sends to artemis and see what Artemis can figure out for itself

@DominicOram
Copy link
Collaborator

Something like:

@bpp.subs_decorator(ispyb_handler)
def ispyb_with_subscriptions():
    yield from get_ispyb_hardware_params()

yield from ispyb_with_subscriptions()
dc_id = ispyb_handler.get_dcid()

yield from run_gridscan(md={"dc_id": dc_id})

@DominicOram
Copy link
Collaborator

I think this has instead been solved with #1192

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rotation scan Preparing for implementation of rotation scans
Projects
Archived in project
Development

No branches or pull requests

2 participants