Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Deploy and test v9.2.0 #1343

Closed
DominicOram opened this issue Apr 30, 2024 · 4 comments · Fixed by #1361
Closed

Deploy and test v9.2.0 #1343

DominicOram opened this issue Apr 30, 2024 · 4 comments · Fixed by #1361
Assignees
Labels
needed_for_release Issues that must be complete before the next release

Comments

@DominicOram
Copy link
Collaborator

We want the latest version of Hyperion to work

@DominicOram DominicOram self-assigned this Apr 30, 2024
@DominicOram
Copy link
Collaborator Author

DominicOram commented Apr 30, 2024

Issues from testing 30/04/24

    pip install "starlette<0.28.0,>=0.27.0"
    pip install stomp.py==8.1.0
{'beamline': 'i03',
 'dc_comments': 'Hyperion: Xray centring - Diffraction grid scan of 30 by 22 '
                'images in 20.0 um by 20.0 um steps. Top left (px): [477,285], '
                'bottom right (px): [686,438].',
 'file': '/dls/i03/data/2024/cm37235-2/xraycentring/TestInsulin/ins_9/ins_9_52_master.h5',
 'ispyb_expected_images': '660',
 'ispyb_wavelength': '0.976292',
 'reason': 'HDF5 file '
           '/dls/i03/data/2024/cm37235-2/xraycentring/TestInsulin/ins_9/ins_9_52_master.h5 '
           'contains invalid pixel_mask: pixel_mask inconsistent with '
           'data_size (pixel_mask.shape=(2162, 2068) data_size=(4362, 4148))'}
  • fixed by setting ROI correctly in GDA params and in Hyperion params
  • Issue with rotation params not being sent from GDA correctly. Stopped for the day

@DominicOram
Copy link
Collaborator Author

DominicOram commented May 2, 2024

Testing 02/05/2024

@DominicOram
Copy link
Collaborator Author

DominicOram commented May 3, 2024

Also saw an issue where screen + collect wasn't working. This was due to experiment type not being passed in from GDA -> Hyperion correctly - follow up in #1360

@DominicOram
Copy link
Collaborator Author

Also couldn't get robot loads to work, follow up on #1348

@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label May 15, 2024
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue May 16, 2024
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue May 16, 2024
* (DiamondLightSource/hyperion#1343) OAV should make snapshot folder if it doesn't exist

* (DiamondLightSource/hyperion#1343) Address review comments
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needed_for_release Issues that must be complete before the next release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant