Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Modify the callbacks to use the new external param classes #1276

Closed
dperl-dls opened this issue Mar 19, 2024 · 2 comments · Fixed by #1366
Closed

Modify the callbacks to use the new external param classes #1276

dperl-dls opened this issue Mar 19, 2024 · 2 comments · Fixed by #1366
Assignees
@dperl-dls

Comments

@dperl-dls
Copy link
Collaborator

dperl-dls commented Mar 19, 2024 •
edited by DominicOram
Loading

See #1092 and #1275

Acceptance Criteria

  • The callbacks use the new parameters and have no dependency on the old models
  • Tests all pass
  • In doing this think about callback structure, what parameters it needs and spin out new issues if there are ways to simplify
@dperl-dls dperl-dls mentioned this issue Mar 19, 2024
Closed
5 tasks
@DominicOram
Copy link
Collaborator

Depends on #1279 and #698

@DominicOram
Copy link
Collaborator

We think a M

@dperl-dls dperl-dls self-assigned this May 8, 2024
@dperl-dls dperl-dls mentioned this issue May 8, 2024
Merged
dperl-dls added a commit that referenced this issue May 9, 2024
@dperl-dls
#1277 #1276 fix nexus issues
ad06fe5
dperl-dls added a commit that referenced this issue May 9, 2024
@dperl-dls
#1277 #1276 fix ispyb issues
9b38ca2
dperl-dls added a commit that referenced this issue May 9, 2024
@dperl-dls
#1277 #1276 fix merge issues
2a46f7f
dperl-dls added a commit that referenced this issue May 9, 2024
@dperl-dls
(#1277) (#1276) fix merge issues
460c564
dperl-dls added a commit that referenced this issue May 16, 2024
@dperl-dls
#1277 #1276 fix nexus issues
32b9fc0
dperl-dls added a commit that referenced this issue May 16, 2024
@dperl-dls
#1277 #1276 fix ispyb issues
641eae1
dperl-dls added a commit that referenced this issue May 16, 2024
@dperl-dls
(#1277) (#1276) fix merge issues
e614b5b
DominicOram added a commit that referenced this issue May 21, 2024
@DominicOram
(#1276) RotationNexusFileCallback does not need to hold on to parameters
776dac4
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1277 DiamondLightSource/hyperion#1276 fix…
cd37ded 
… nexus issues
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1277 DiamondLightSource/hyperion#1276 fix…
1982cef 
… ispyb issues
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
(DiamondLightSource/hyperion#1277) (DiamondLightSource/hyperion#1276)…
7f31de8 
… fix merge issues
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1276) RotationNexusFileCallback does not…
db1be69 
… need to hold on to parameters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dperl-dls dperl-dls

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete conversion to new parameter model DiamondLightSource/hyperion
2 participants
@DominicOram @dperl-dls