Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Discussion: Reduce nexgen logs #1168

Closed
DominicOram opened this issue Feb 19, 2024 · 7 comments
Closed

Discussion: Reduce nexgen logs #1168

DominicOram opened this issue Feb 19, 2024 · 7 comments
Assignees

Comments

@DominicOram
Copy link
Collaborator

Now that we're forwarding nexgen info logs to graylog they're getting a bit chatty as nexgen logs for each part of the nexus file it's writing and we are writing two files. We should discuss which of these logs are useful to Hyperion/other users of nexgen and change either the logs in nexgen or the logging level we forward to graylog

Acceptance Criteria

  • We decide which logs we want
  • We hide the logs we don't want
@DominicOram
Copy link
Collaborator Author

@noemifrisina and @dperl-dls - thoughts?

@noemifrisina
Copy link
Contributor

In short, YES.
In general, the logging in nexgen is in serious need of tidying up - both the set up and the individual message logging levels. One of those tasks that keeps getting pushed back, might be a good time to finally get to it...
In any case, not sure what level we're sending to Graylog right now but most of the nexgen logs should be below it.
I'd like to keep a file handler where to send most of the messages because they're useful to debug issues eg. for Tristan or ssx (or, more in general, things outside Hyperion), but that can be disabled. I think we definitely don't need to send all these chatty logs to graylog, it should be enough to have a "file is written" or "file writing failed - here's why"

@DominicOram
Copy link
Collaborator Author

See here for an example of the nexgen logs we're getting in graylog

@DominicOram
Copy link
Collaborator Author

Maybe a good first nexgen issue for @phathaway?

@noemifrisina
Copy link
Contributor

See here for an example of the nexgen logs we're getting in graylog

Yeah, I figure they'd look something like that... Also a good example of how messy the logging levels are, most of those should be set to debug now.

@noemifrisina
Copy link
Contributor

Maybe a good first nexgen issue for @phathaway?

Could be yes. I'll write the issue in nexgen - with a few more details

@DominicOram
Copy link
Collaborator Author

Closing as fixed by DiamondLightSource/nexgen#240

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants