This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Be clear about desired vs actual transmission #1033
Comments
We think 1 day |
dperl-dls
added a commit
that referenced
this issue
Mar 18, 2024
dperl-dls
added a commit
that referenced
this issue
Mar 18, 2024
dperl-dls
added a commit
that referenced
this issue
Mar 18, 2024
This was referenced Mar 18, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this issue
Aug 23, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this issue
Aug 23, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this issue
Aug 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, inside xray centring, we take the transmission specified in the ispyb section of the supplied parameters to mean the desired transmission and set it on the device. We then read this back to find the actual transmission and put that back in the ispyb params object to put in ispyb.
We should instead specify the desired transmission as part of the experiment parameters, then use that to set on the hardware and read the actual back from there to put in ispyb. Note that the removal of the putting the readback into
ispyb_params
will be done as the last part of #1218. So this issue mostly boils down to move desired_transmission into the experiment params (not in the base class as not used byPinTipCentring
)Acceptance Criteria
ispyb_params
for thisThe text was updated successfully, but these errors were encountered: