Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Be clear about desired vs actual transmission #1033

Closed
DominicOram opened this issue Dec 8, 2023 · 1 comment · Fixed by #1271
Closed

Be clear about desired vs actual transmission #1033

DominicOram opened this issue Dec 8, 2023 · 1 comment · Fixed by #1271
Assignees

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Dec 8, 2023

Currently, inside xray centring, we take the transmission specified in the ispyb section of the supplied parameters to mean the desired transmission and set it on the device. We then read this back to find the actual transmission and put that back in the ispyb params object to put in ispyb.

We should instead specify the desired transmission as part of the experiment parameters, then use that to set on the hardware and read the actual back from there to put in ispyb. Note that the removal of the putting the readback into ispyb_params will be done as the last part of #1218. So this issue mostly boils down to move desired_transmission into the experiment params (not in the base class as not used by PinTipCentring)

Acceptance Criteria

  • The desired transmission is set in the experiment params
  • Plans no longer make reference to ispyb_params for this
@DominicOram
Copy link
Collaborator Author

We think 1 day

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants