Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

ISPYB: Deposit robot load entry #1017

Closed
DominicOram opened this issue Dec 2, 2023 · 8 comments · Fixed by #1291
Closed

ISPYB: Deposit robot load entry #1017

DominicOram opened this issue Dec 2, 2023 · 8 comments · Fixed by #1291
Assignees

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Dec 2, 2023

With Hyperion starting to do the robot load we should be putting the robot load entry into ispyb.

Additionally, we would like to do this with the new ispyb REST interface, exp-eye.

Acceptance Criteria

  • There is an ispyb callback to put the robot load data into ispyb
  • There are sufficient tests for this
@DominicOram
Copy link
Collaborator Author

From looking at current collections it looks like:

  • snapshot_after is actually a snapshot of the webcam view after robot load
  • snapshot_before is actually a snapshot after load but from the OAV view

@DominicOram
Copy link
Collaborator Author

GDA actually starts the robot load entry, we just need GDA to pass in the id and we can finish it. See loads on https://ispyb.diamond.ac.uk/samples/sid/5054101

@DominicOram
Copy link
Collaborator Author

Note that we're not actually going to use this yet, see #1047 (comment)

@DominicOram
Copy link
Collaborator Author

#1055 contains a good start that whoever picks this up can run with but I don't think it's worth trying to get this in now so putting it on the backlog

@DominicOram DominicOram removed their assignment Jan 29, 2024
@DominicOram
Copy link
Collaborator Author

FYI @gfrn. I started some work on this a month ago in the associated PR but dropped it for more urgent things. We would like to try again at some point in March but no fixed idea of when yet.

@DominicOram
Copy link
Collaborator Author

Ignore the snapshots part for now, will be done as part of #1282

@DominicOram
Copy link
Collaborator Author

Using existing python API we think S
Using new REST interface we think M

@DominicOram - work out which of these we use

@DominicOram
Copy link
Collaborator Author

Discussed with @NKatti2011, we should use exp-eye.

olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
1 participant