use devicevector

[stan-dot]

Fixes #795

Instructions to reviewer on how to test:

1. Do dodal connect i22
2. Confirm connection happens
3. Do dodal connect p38
4. Confirm sim mode connection happens

Checks for reviewer

• Would the PR title make sense to a scientist on a set of release notes
• If a new device has been added does it follow the standards
• If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
• Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (eece064) to head (18dbbeb).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   94.99%   94.97%   -0.03%     
==========================================
  Files         115      115              
  Lines        4719     4698      -21     
==========================================
- Hits         4483     4462      -21     
  Misses        236      236              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DominicOram]

I think this is a worse interface for the users. The grouping of devices in the beamline file should be logical to a scientist as that is their interface with the devices. They do not think of the slits on the beamline as one large device with multiple slits but rather as individual devices. So they would want to define a plan like def slit_scan(slit: Slits = inject("slits_1")). This also brings the issue of how we deal with disconnected slits. It is very possible that the beamline may have one slit set offline but still want to use the others. With SixSlits the whole device will fail to connect and throw errors.

[stan-dot]

@DominicOram at the moment I only see the Slits device used at i22 and p38, where I know the scientists and their ways of working and for now they don't write tests themselves. And the device is just in the devices/i22 folder and any beamline can use the single Slits device however they want.

With SixSlits the whole device will fail to connect and throw errors.

that is a valid point, might need a decorator 'allow fail'? I am not sure if the slits are used independently like what you're describing now at i22

[DiamondJoseph]

If we go this way I don't think it should be called six_slits: we'd still be able to address individual slits with e.g. inject by doing inject = ("slits.1") (NB: Might not work for device vectors? Would this work with inject("slits[1]")?)

[stan-dot]

at the latest version it's a SlitsCollection. testing out ipython behavior of device factor shortly

[stan-dot]

@DominicOram what is a plan that you'd like to define in ipython and then run it that the inject behavior would be used?

[DominicOram]

@DominicOram what is a plan that you'd like to define in ipython and then run it that the inject behaviour would be used?

Something like:

def slit_scan(slit: Slits = inject("slits_1"), i0: TetrammDetector = inject("i0"):
    yield from bps.scan([i0], slit.x, 0, 100)

[stan-dot]

ok how do I get the beamline module to be referred to with inject?

I don't see this in tutorials

search also does not provide information on the use of dodal in ipython https://diamondlightsource.github.io/dodal/main/search.html?q=ipython