Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make device factory decorator #597

Open
wants to merge 67 commits into
base: main
Choose a base branch
from
Open

make device factory decorator #597

wants to merge 67 commits into from

Commits on Sep 25, 2024

  1. example beamline with implementation

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6d1e89b View commit details
    Browse the repository at this point in the history

  2. small cleanup

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dd9036f View commit details
    Browse the repository at this point in the history

  3. added controller demonstration

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5cf60d0 View commit details
    Browse the repository at this point in the history

  4. fix wrong extension

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    538f96f View commit details
    Browse the repository at this point in the history

  5. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    85d1d7e View commit details
    Browse the repository at this point in the history

  6. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dcf1586 View commit details
    Browse the repository at this point in the history

  7. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dbabb07 View commit details
    Browse the repository at this point in the history

  8. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <[email protected]>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    af74ac6 View commit details
    Browse the repository at this point in the history

  9. fix example beamline into a dataclass

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ce52660 View commit details
    Browse the repository at this point in the history

  10. new-i22 as an example

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    25ee88c View commit details
    Browse the repository at this point in the history

  11. respond to feedback

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dc840be View commit details
    Browse the repository at this point in the history

  12. respond to comments

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b017502 View commit details
    Browse the repository at this point in the history

  13. initial test

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e5b6715 View commit details
    Browse the repository at this point in the history

  14. comment out some tests to check coverage

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7e53897 View commit details
    Browse the repository at this point in the history

  15. lint

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3fdbe46 View commit details
    Browse the repository at this point in the history

  16. use factory name for active devices dict key

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b548d6d View commit details
    Browse the repository at this point in the history

  17. this cannot be active devices, globals harder to mock

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    992f8b0 View commit details
    Browse the repository at this point in the history

  18. amend the test

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ccae219 View commit details
    Browse the repository at this point in the history

  19. added a red test for caching by name

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ed434a3 View commit details
    Browse the repository at this point in the history

  20. fix the tests and add the support for a name flag

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d10d6d7 View commit details
    Browse the repository at this point in the history

  21. add the API for blueapi

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f64975d View commit details
    Browse the repository at this point in the history

  22. remove todos

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    88ee2e2 View commit details
    Browse the repository at this point in the history

  23. unused utils deleted for coverage

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    29a22b0 View commit details
    Browse the repository at this point in the history

  24. Just one i22 now

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4b3235d View commit details
    Browse the repository at this point in the history

  25. respond to comments

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    069381a View commit details
    Browse the repository at this point in the history

  26. rename to device factory

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c295f05 View commit details
    Browse the repository at this point in the history

  27. is this enough to replace skip_device()

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f9dad19 View commit details
    Browse the repository at this point in the history

  28. ruff

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    19e3bac View commit details
    Browse the repository at this point in the history

  29. remove the connect default timeout =10

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    166f58b View commit details
    Browse the repository at this point in the history

  30. add support for the terminal use case and some tests

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d9356d7 View commit details
    Browse the repository at this point in the history

  31. fix mock status and add the new decorator@

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f93319d View commit details
    Browse the repository at this point in the history

  32. fix the tests

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e8b0b74 View commit details
    Browse the repository at this point in the history

  33. delete bad comments, add good comments

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0748039 View commit details
    Browse the repository at this point in the history

  34. ruff

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    22f307c View commit details
    Browse the repository at this point in the history

  35. feedback response

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4e33ae5 View commit details
    Browse the repository at this point in the history

  36. add return type annotation for testing coverage purposes

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    786fc65 View commit details
    Browse the repository at this point in the history

  37. respond to feedback

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a0efba7 View commit details
    Browse the repository at this point in the history

  38. adapt tetramm

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9306ba6 View commit details
    Browse the repository at this point in the history

  39. respond to feedback

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e41f7b7 View commit details
    Browse the repository at this point in the history

  40. add repr that includes the config

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    84e640b View commit details
    Browse the repository at this point in the history

  41. lint

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    80cded5 View commit details
    Browse the repository at this point in the history

  42. remove old panda ref

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    924b97c View commit details
    Browse the repository at this point in the history

  43. fix import

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0455eb8 View commit details
    Browse the repository at this point in the history

  44. fix the tests

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7a64267 View commit details
    Browse the repository at this point in the history

  45. pin pyright version due to is_device check failing

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f22c1ac View commit details
    Browse the repository at this point in the history

  46. cancel pyright pinning

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dbbb974 View commit details
    Browse the repository at this point in the history

  47. renaming

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    62d13a7 View commit details
    Browse the repository at this point in the history

  48. partial update to fix the test coverage for the factory

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5b06829 View commit details
    Browse the repository at this point in the history

  49. maybe fixed

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4c545ad View commit details
    Browse the repository at this point in the history

  50. imports fix

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0d27715 View commit details
    Browse the repository at this point in the history

  51. fix imports

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5c3441c View commit details
    Browse the repository at this point in the history

  52. forgot one

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    69e2139 View commit details
    Browse the repository at this point in the history

  53. added test to increase coverage, still broken a bit

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2de70eb View commit details
    Browse the repository at this point in the history

  54. towards a stable problem definitio a stable problme definition

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d7e72b7 View commit details
    Browse the repository at this point in the history

  55. fix the test instance

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a7c8d11 View commit details
    Browse the repository at this point in the history

  56. finally fixed tests

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3ba106c View commit details
    Browse the repository at this point in the history

  57. lint

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    23116ea View commit details
    Browse the repository at this point in the history

  58. fix tests

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e240056 View commit details
    Browse the repository at this point in the history

  59. exit some tests early

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    edcb5c4 View commit details
    Browse the repository at this point in the history

  60. remove pytest skip

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5643473 View commit details
    Browse the repository at this point in the history

  61. hardcode the i22 slit refs

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9595f95 View commit details
    Browse the repository at this point in the history

  62. i22 remove device_instantiation

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4573095 View commit details
    Browse the repository at this point in the history

  63. respond to feedback

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    686fc25 View commit details
    Browse the repository at this point in the history

  64. more tests to raise coverage

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bc4cf6f View commit details
    Browse the repository at this point in the history

  65. respond to comment on the connect logic in controller call

    @stan-dot
    stan-dot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2f20ee3 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. deprecation warning added

    @stan-dot
    stan-dot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f224a17 View commit details
    Browse the repository at this point in the history

  2. remove the v1 ophyd relevant piece of logic - fake_with_ophyd_sim

    @stan-dot
    stan-dot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f188505 View commit details
    Browse the repository at this point in the history