-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalise Slits Implementations #462
Rationalise Slits Implementations #462
Comments
Create ophyd-async version of `S4SlitGaps`. To be rationalised in #462 * Port S4SlitGaps to ophyd-async and add tests * Add I22 and P38 config for slit gaps * Add docstrings to slit gaps
The new PVs are now on i03, we can switch over to using them |
To do the i03 + i22 merge:
|
Blocked on the PVs not being as we expected. Working with controls on this |
Sorry, late to the thread.
These slits implement a different Ophyd class for each set of slits that have different PV names, American vs British English, etc. (it was to just get stuff working, not very well thought out.) There are other problems with my slit implementation (such as relying on a class I wrote that is essentially just a Motor, very rudimentary simulator, etc.) so I would be happy to edit my Bluesky plan to use whichever slit implementation you choose. Happy to talk in person if this doesn't help! |
mx-controls say they can make the PV naming consistent during next shutdown (CENTRE over CENTER) |
this reappered at i18 |
also this is relevant |
I'd like to comment that in future I would expect all containerised motor IOCs with gap and centre slits to be using the template in the pmac module. So this is what we should be aiming for, or if not then we need to change it to what we want: |
Dodal now has three attempts at a device to control 4-blade slits sets. One from #431, one from #315 and one originally imported from Hyperion: https://github.com/DiamondLightSource/dodal/blob/main/src/dodal/devices/s4_slit_gaps.py
As a developer I would like to rationalise them into a single device so I can reduce technical debt. See additional discussion in #384. Current work for the Hypersion slits and #431 requires underlying EPICS implementations to be rationalised first. From @DominicOram: this is being tracked internally at https://jira.diamond.ac.uk/browse/I03-956. Currently unsure if the #315 slits can also operate on the same of PVs, @dan-fernandes may be able to comment.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: