Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 3.12 #222

Closed
DominicOram opened this issue Oct 29, 2023 · 4 comments · Fixed by #859
Closed

Add support for 3.12 #222

DominicOram opened this issue Oct 29, 2023 · 4 comments · Fixed by #859

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Oct 29, 2023 •
edited by dperl-dls
Loading

Python 3.12 is now out, we should add support for it to keep up to date.

Depends on p4p compatibility epics-base/p4p#126

Acceptance Criteria

  • Non-test builds are unpinned (e.g. reverse b980f9b)
  • CI runs tests under 3.12
  • CI all still passes
  • Documentation is updated to reflect we support 3.12
@stan-dot
Copy link
Contributor

stan-dot commented Jul 9, 2024

update:
original p4p PR was closed.

This PR is where it seems the cutting edge is
epics-base/p4p#141

@stan-dot
Copy link
Contributor

latest main branch seems to support 3.12 https://github.com/DiamondLightSource/dodal/blob/main/pyproject.toml

can we close this @DominicOram ?

@DominicOram
Copy link
Contributor Author

Not until CI is in properly

dodal/.github/workflows/ci.yml

Line 24 in 46132f0

python-version: ["3.10", "3.11"] # add 3.12 when p4p #145 is fixed

@stan-dot
Copy link
Contributor

ah right I forgot about this

@dperl-dls dperl-dls mentioned this issue Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add python 3.12 to CI DiamondLightSource/dodal
2 participants
@DominicOram @stan-dot