Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc build broken #218

Closed
DominicOram opened this issue Oct 26, 2023 · 2 comments · Fixed by #221
Closed

Doc build broken #218

DominicOram opened this issue Oct 26, 2023 · 2 comments · Fixed by #221
Assignees
@DominicOram

Comments

@DominicOram
Copy link
Contributor

The docs build is broken in CI e.g. https://github.com/DiamondLightSource/dodal/actions/runs/6642933356/job/18074448752?pr=216

Acceptance Criteria

  • Doc build in CI works
@DominicOram DominicOram self-assigned this Oct 26, 2023
@DominicOram
Copy link
Contributor Author

DominicOram commented Oct 26, 2023 •
edited
Loading

Issue is broken in the pip skeleton too. The latest version of pydata-sphinx-theme introduces a warning that we treat as an error. Linked commit fixes it but sounds like @rosesyrett has a fix in the skeleton that we might be able to just cherry-pick in

DominicOram added a commit that referenced this issue Oct 26, 2023
@DominicOram
(#218) Fix doc build from updated dependency
e5c0448
@DominicOram DominicOram mentioned this issue Oct 27, 2023
Open
DominicOram added a commit that referenced this issue Oct 28, 2023
@DominicOram
(#218) Fix docs build by providing default arg
60b3d72
@DominicOram DominicOram mentioned this issue Oct 28, 2023
Merged
2 tasks
@DominicOram
Copy link
Contributor Author

Additionally, the build is broken in 3.12 due to epics-base/p4p#126, we should pin the python version to 3.11 until that is merged

DominicOram added a commit that referenced this issue Oct 29, 2023
@DominicOram
(#218) Pin builds to 3.11 as p4p doesn't build in 3.12
b980f9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominicOram DominicOram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docs build DiamondLightSource/dodal
1 participant
@DominicOram