Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Fall Over if a Device Does not Connect #444

Closed
callumforrester opened this issue Apr 30, 2024 · 1 comment · Fixed by #468 or DiamondLightSource/dodal#550
Closed

Don't Fall Over if a Device Does not Connect #444

callumforrester opened this issue Apr 30, 2024 · 1 comment · Fixed by #468 or DiamondLightSource/dodal#550
Labels
enhancement New feature or request worker Relates to worker code

Comments

@callumforrester
Copy link
Contributor

As a user I would still like to use blueapi if a particular device fails to connect, assuming there are still plans available that can be used without it, so I can continue operations even if a PV is wrong or a device is unavailable.

This is relevant to, but distinct from #440. If this issue is implemented we expect blueapi to start even if a device does not connect but fall over if we try to use it. Implementing #440 would mean it gives a sensible error if we try to use it.

Implementing this behaviour would also be inkeeping with #285. Blueapi's design philosophy seems to be evolving towards: "start even if there's nothing you can use, and report it".

Possible Solution

Currently unsure if the code change required is in blueapi or dodal

Acceptance Criteria

  • If an error occurs instantiating or connecting to a device, blueapi still starts up
  • In this circumstance, the devices that did successfully instantiate or connect are still available in blueapi
  • There are tests that prove this
@callumforrester
Copy link
Contributor Author

This shouldn't have been closed with #468 still open

callumforrester added a commit that referenced this issue May 31, 2024
closes #444

With PR for dodal at
DiamondLightSource/dodal#550

---------

Co-authored-by: Callum Forrester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request worker Relates to worker code
Projects
None yet
2 participants