Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ophyd-async connect logic to dodal #387

Closed
callumforrester opened this issue Mar 14, 2024 · 4 comments
Closed

Move ophyd-async connect logic to dodal #387

callumforrester opened this issue Mar 14, 2024 · 4 comments
Labels
good first issue Good for newcomers worker Relates to worker code

Comments

@callumforrester
Copy link
Contributor

Blueapi should be agnostic to how devices are connected, dodal should handle that.
There is currently a util module for handling connections, that should move to dodal and blueapi should just call a connect hook or similar

@callumforrester callumforrester added good first issue Good for newcomers worker Relates to worker code labels Mar 14, 2024
@callumforrester
Copy link
Contributor Author

Additionally, there is duplication at work here: Dodal has its own version here: https://github.com/DiamondLightSource/dodal/blob/4cd34cfbdc9e9fc3e963a0a88db36b6a79cc463a/src/dodal/beamlines/beamline_utils.py#L48

We should have a single, consistent space for this logic that behaves in the same way everywhere to reduce ambiguity and minimize the chance of a mistake when debugging.

@stan-dot stan-dot added this to the Refactor of the core logic milestone May 16, 2024
@stan-dot
Copy link
Contributor

stan-dot commented Jun 3, 2024

@coretl what do you think about this?

@coretl
Copy link
Contributor

coretl commented Jun 3, 2024

DiamondLightSource/dodal#483 and #440 are relevant

@callumforrester
Copy link
Contributor Author

This issue is stale, the logic is now in dodal and not blueapi (it was in both for a while, which we didn't notice because it is idempotent), it was removed in #461.

I will close this, discussion can continue in the issues @coretl linked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers worker Relates to worker code
Projects
None yet
Development

No branches or pull requests

3 participants