Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

[Discussion] Currency unit #165

Open
S1ngS1ng opened this issue Dec 11, 2018 · 1 comment
Open

[Discussion] Currency unit #165

S1ngS1ng opened this issue Dec 11, 2018 · 1 comment

Comments

@S1ngS1ng
Copy link
Contributor

What

The functionality of modifying units, currency for example

Why

  1. Order matters, in some language. Specifically, a common way to express one hundred dollars in Chinese is commonly seen as 100 美元 (where "美元" means US dollar). In the favor of disambiguation, I prefer this way instead of $100. Though, the symbol of the Chinese currency is ¥, which differs from that of US dollar. In the end, it might be just personal preferences. I'd like to hear from others as well.
  2. The rule of group separator criteria might differ. Specifically, we group by 4 digits in Chinese. Hence that 30k would make less sense comparing to 3 万 (where "万" means 10 thousand). I'd like to hear from others as well.
  3. (OPINIONATED) It might make more sense to utilize local currency for translation. Adding the functionality would make it happen.

Reference

#153

@balazsorban44
Copy link
Contributor

It would be more practical if currency would be handled automatically, rather than we hardcoding these things.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString

This could probably be useful. So we could be able to provide only the currency name, and the rest would be done automatically. Don't know, maybe even the values can be fetched from a currecny API like this: https://currency-api.appspot.com/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants