Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of multi-day and multi-shift events #40

Open
iandees opened this issue Aug 23, 2016 · 2 comments
Open

Better handling of multi-day and multi-shift events #40

iandees opened this issue Aug 23, 2016 · 2 comments

Comments

@iandees
Copy link

iandees commented Aug 23, 2016

The events API that we're querying seems to expose multi-shift and multi-day events with individual results for each shift or day in the response, resulting in stuff like this:

image

It'd be nice if we could collapse those into a single result on the left and a single pin on the map and then show "upcoming shifts" or "upcoming days" or something when viewing the details of the event.

Looking at the results from the search API I don't see anything immediately obvious to collapse on, but maybe start with address and see what it looks like?

@wboykinm
Copy link
Collaborator

@iandees This is partly resolved by @kielni's excellent date slider addition, but I'm noticing that there's basically a schema problem with the Cleveland example above. Some events are coming in over the API as fundamental duplicates when there are shifts involved. For example, this payload contains 12 events for the same day at the Cleveland downtown office. 10 of them are scheduled for the same start time. All have unique lookupIds, so they're all unique events as far as the API is concerned.

I dunno, but this seems like an issue to raise with the campaign, and not one we can easily solve here.

@iandees
Copy link
Author

iandees commented Aug 24, 2016

Yep, I agree. It's quite easy to make duplicate events in BSD, so I'm not surprised this is showing up in their response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants