Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onlyUrl and withFullUrl should be resetted to default #46

Open
guestisp opened this issue Oct 4, 2018 · 1 comment
Open

onlyUrl and withFullUrl should be resetted to default #46

guestisp opened this issue Oct 4, 2018 · 1 comment

Comments

@guestisp
Copy link

guestisp commented Oct 4, 2018

As Facades are running with a singleton, if we set onlyUrl or withFullUrl all subsequent calls to Minify would preserve the value of these two flag.

I think both should be resetted to false just before returning from the render function.
guestisp pushed a commit to guestisp/minify that referenced this issue Oct 4, 2018
@gandalfthegreydev
Reset onlyUrl value to default after processing
f8de58a 
Fix DevFactoryCH#46
@guestisp guestisp mentioned this issue Oct 4, 2018
Open
@guestisp
Copy link
Author

guestisp commented Oct 4, 2018

The bug is only related to onlyUrl. withFullUrl is working properly.

Fixed in my PR #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guestisp