Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong weekday name #129

Closed
mblabs opened this issue Feb 8, 2013 · 5 comments
Closed

Wrong weekday name #129

mblabs opened this issue Feb 8, 2013 · 5 comments

Comments

@mblabs
Copy link

mblabs commented Feb 8, 2013

The name of the weekday displayed by the data-source is wrong (shifted by -1 day):

I think the the row 78 in datasources/data.datetime.php

will be:
$date->modify('last Monday');

instead of
$date->modify('last Sunday');

@nilshoerrmann
Copy link
Contributor

What is shifted exactly?

@mblabs
Copy link
Author

mblabs commented Feb 8, 2013

the weekday name:

today :

Friday 8th February

is displayed:

THURSDAY 8th February

@nilshoerrmann
Copy link
Contributor

But isn't that more a problem of your template rather than the Data Source?
The Data Source isn't creating any formatted dates.

How does your template look like?

@jonmifsud
Copy link
Contributor

@nilshoerrmann if I had to put my take on this (if you're going for some config options. I would modify line 108 $config = 0; or 1 depending on the offset. Seems to me like PHP uses dates from 0-6 [Sun-Sat]

@nilshoerrmann
Copy link
Contributor

This will be solved with #130.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants