Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify configuration logic in CI #512

Closed
2 tasks done
p-senichenkov opened this issue Jan 10, 2025 · 0 comments · Fixed by #513
Closed
2 tasks done

Simplify configuration logic in CI #512

p-senichenkov opened this issue Jan 10, 2025 · 0 comments · Fixed by #513
Assignees
@p-senichenkov @Vdaleke
Labels
chore Performance upgrade or technical debt

Comments

@p-senichenkov
Copy link
Collaborator

p-senichenkov commented Jan 10, 2025 •
edited
Loading

Need to simplify (or at least generalize) configuration selection logic in core-tests.yml and binding-tests.yml.

  • Firstly, it seems that separate action with exports will be more readable. Also, such action could be reused in core-tests and binding-tests:

It seems to me that a composite action will be more readable, but will it be possible to implement logic with a bad configuration?

Originally posted by @Vdaleke in #507 (comment)

  • Secondly, some kind of global mapping from OS names (e. g. ubuntu) to runner full names (e. g. ubuntu-latest) is needed. It will simplify matrix and workflow names, displayed on GitHub. Also, it will help to use the same runner image in all workflows
@p-senichenkov p-senichenkov added the chore Performance upgrade or technical debt label Jan 10, 2025
@Vdaleke Vdaleke mentioned this issue Jan 11, 2025
Merged
@Vdaleke Vdaleke mentioned this issue Jan 27, 2025
Merged
Vdaleke added a commit to Vdaleke/desbordante-core that referenced this issue Jan 29, 2025
@Vdaleke
Refactor CI
9f2405f 
Set libraries download in alphabetical order.
Bump actions/checkout to v4.
Change run_tests matrix to more readable.
Add env field to avoid code duplications inside job. resolves Desbordante#512
Vdaleke added a commit to Vdaleke/desbordante-core that referenced this issue Jan 29, 2025
@Vdaleke
Refactor CI
fc2101e 
Set libraries download in alphabetical order.
Bump actions/checkout to v4.
Change run_tests matrix to more readable.
Add env field to avoid code duplications inside job. resolves Desbordante#512
Vdaleke added a commit to p-senichenkov/Desbordante that referenced this issue Jan 29, 2025
@Vdaleke
Refactor CI
33461cf 
Set libraries download in alphabetical order.
Bump actions/checkout to v4.
Change run_tests matrix to more readable.
Add env field to avoid code duplications inside job. resolves Desbordante#512
Vdaleke added a commit to p-senichenkov/Desbordante that referenced this issue Jan 29, 2025
@Vdaleke
Refactor CI
9e563fc 
Set libraries download in alphabetical order.
Bump actions/checkout to v4.
Change run_tests matrix to more readable.
Add env field to avoid code duplications inside job. resolves Desbordante#512
Vdaleke added a commit to p-senichenkov/Desbordante that referenced this issue Jan 30, 2025
@Vdaleke
Refactor CI
5270ad9 
Set libraries download in alphabetical order.
Bump actions/checkout to v4.
Change run_tests matrix to more readable.
Add env field to avoid code duplications inside job. resolves Desbordante#512
p-senichenkov pushed a commit to p-senichenkov/Desbordante that referenced this issue Jan 30, 2025
@Vdaleke @p-senichenkov
Refactor CI
df056ba 
Set libraries download in alphabetical order.
Bump actions/checkout to v4.
Change run_tests matrix to more readable.
Add env field to avoid code duplications inside job. resolves Desbordante#512
p-senichenkov pushed a commit to p-senichenkov/Desbordante that referenced this issue Jan 30, 2025
@Vdaleke @p-senichenkov
Refactor CI
8c9450c 
Set libraries download in alphabetical order.
Bump actions/checkout to v4.
Change run_tests matrix to more readable.
Add env field to avoid code duplications inside job. resolves Desbordante#512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-senichenkov p-senichenkov

@Vdaleke Vdaleke

Labels
chore Performance upgrade or technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add macOS pip-packages. Add GCC-macOS configuration to CI. Vdaleke/desbordante-core
2 participants
@p-senichenkov @Vdaleke