-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Add Version" Create Button Should Be Inactive Until Version Provided #995
Comments
Hi, I think it should also have a backend validation for the request body to check if the version value is provided and correct, however, a client-side validation is very useful from the UX and the program side. I can look into this issue, does this issue need to be assigned to me or can I fix and open a PR for it? Please let me know. |
@IdrisGit, you can normally just start working on an issue and submit a PR, but assigning the issue to you is a process improvement because then others can see that the issue is "spoken for". That's especially valuable right at the moment during Hacktoberfest. Are you participating in Hacktoberfest? If you are not then let us know and the hackoberfest label can be removed from this issue. |
Sure, I will start working on it. |
I am trying to setup and test out my changes locally, I am able to launch the dev server for the frontend and the backend, frontend requires login credentials, are there any default values or a bypass method that I can use to test locally, or do I need to setup the database and users table? |
hi @IdrisGit , the default credentials can be found here: https://docs.dependencytrack.org/getting-started/initial-startup/ |
@IdrisGit, thanks again for the contribution.
It is intentional. Or, rather, it perhaps "was originally intentional" in the days before the ability to clone a project was introduced. I have several projects in my production system that have been created without versions and they all work perfectly fine. I am sure that things can be improved and things might be re-evaluated in the future after collection projects, etc, are introduced. Having said that, I have tested new project creation and perhaps logging can be improved. |
Let me know if there some task that I can look into for the project creation and logging. |
Current Behavior
In the Frontend, a new project version can be created via
View Details
->Add Version
The resulting dialog has a create button that is active. Clicking it without providing a Version string will result in an HTTP 400 error and some 190 lines of exception logging in the server log, starting with...
If an admin is looking at the logs then they have absolutely no context for what caused the exception.
Proposed Behavior
The "Create" button should be inactive until something has been provided in the "Version" field.
Checklist
The text was updated successfully, but these errors were encountered: