New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class name is not consistent with naming convention #260

Open

Saloshp opened this issue Apr 22, 2019 · 4 comments

Saloshp commented Apr 22, 2019

python-sc2/examples/terran/onebase_battlecruiser.py

Line 9 in 608bd25

class ProxyRaxBot(sc2.BotAI):

Matuiss2 commented Apr 24, 2019

What do you mean? It does follow it. https://www.python.org/dev/peps/pep-0008/#class-names

Collaborator

BurnySc2 commented Apr 24, 2019 •

edited

Loading

He means that the OneBaseBattleCruiserBot is called ProxyRaxBot, that would be my guess.

Author

Saloshp commented Apr 24, 2019

@Matuiss2, @BurnySc2 is correct, sry for the unclear description,
May I open a PR for these small types of bugs?

Collaborator

BurnySc2 commented Apr 24, 2019

Yes, please use the develop branch for the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment