Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant folding warnings come in pretty late and we could get spurious warnings when combined with monomorphization #99

Open
DenialAdams opened this issue Jun 17, 2023 · 2 comments
Open

Constant folding warnings come in pretty late and we could get spurious warnings when combined with monomorphization #99

DenialAdams opened this issue Jun 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@DenialAdams
Copy link
Owner

Maybe it's better if we run constant folding before monomorphization and just accept we will miss some chances
@DenialAdams
Copy link
Owner Author

Maybe it's better if we run constant folding before monomorphization and just accept we will miss some chances

Well, we need to fold builtins, but maybe we could turn off warnings on the second pass

@DenialAdams DenialAdams added the bug Something isn't working label Dec 15, 2023
@DenialAdams
Copy link
Owner Author

Maybe it's better if we run constant folding before monomorphization and just accept we will miss some chances

Monomorphization is now a pre-requisite for type checking, so this is no longer possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DenialAdams