Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volatility for Glicko2Rating::unrated() should be specified #8

Open
halvnykterist opened this issue Jan 21, 2022 · 2 comments
Open

Comments

@halvnykterist
Copy link

Hi!

I'm using the library to calculate ratings for http://ratingupdate.info/, and was running into an issue with deviations increasing quite rapidly over time, despite the system constant being very low. After debugging a bit, I came to the conclusion that new glicko2 ratings had a volatility of 0.06 assigned was the problem.

In the original paper, the text is:

Set the player’s volatility to 0.06 (this value depends on the particular application).

This does mean that From<GlickoRating> on Glicko2Rating isn't really something that can be implemented, which has implications for the rest of the API.

@DenialAdams
Copy link
Owner

Thank you for the feedback, sorry that you had trouble!

I'll look into this today - I guess at a bare minimum we should create a method Glicko2Rating::from_glicko_rating_with_volaitility, and then we can decide if we want to also remove the From impl.

@halvnykterist
Copy link
Author

Yeah, that sounds about right. I think a better "uninitialized" constructor would be good, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants