Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate elections/regions causes poor postcode search results #87

Closed
jf1 opened this issue Apr 10, 2017 · 7 comments
Closed

Duplicate elections/regions causes poor postcode search results #87

jf1 opened this issue Apr 10, 2017 · 7 comments

Comments

@jf1
Copy link

jf1 commented Apr 10, 2017

There's no similar problem in WM (this works fine) so I suspect the problem is caused by the list of current posts including:
Greater Manchester
Liverpool City Region
and also:
Mayor of Greater Manchester
Mayor of Liverpool City Region

Unfortunately this search leads directly to https://candidates.democracyclub.org.uk/areas/combined-authority--combined-authority:greater-manchester-ca
Which states: Known candidates for Greater Manchester in the Greater Manchester - Oh no! We don’t know of any candidates in Greater Manchester for the Greater Manchester yet.

It should lead to this post.

Also, given this election, results for this search should also include this post.

@symroe
Copy link
Member

symroe commented Apr 12, 2017

Thanks @jf1.

The posts were actually the wrong way around, with the ones with candidates in being older posts that mistook Liverpool and Manchester councils for the CAs. Candidates have been moved to the correct posts now, and the postcode searches work.

On the Gorton election, I'm looking in to it now.

@symroe
Copy link
Member

symroe commented Apr 12, 2017

Gorton fixed now, but you might not be able to see the fix if your browser has cached the redirect between the search and the old URL. Clearing a cache should make it work.

@symroe symroe closed this as completed Apr 12, 2017
@jf1
Copy link
Author

jf1 commented Apr 12, 2017

Thanks @symroe, postcode handled much better however I'm not convinced the GM election/post descriptions that are in use are correct.

They're: Known candidates for Greater Manchester in the Greater Manchester
I'd settle for: Known candidates for Mayor of Greater Manchester in the Greater Manchester Combined Authority

For Gorton it's currently:
Known candidates for Manchester, Gorton in the Manchester, Gorton
I suspect this would need agreement on standardised election names for it to become eg:
Known candidates for Manchester, Gorton in the May 2017 Parliamentary By-election

Also, there's a third election for some in GM - this search should lead to the Mayor, MP and a ward by-election. It currently directs to this which shows all candidates for two elections on one page - would this be better as a list of the current elections for that postcode?

@jf1
Copy link
Author

jf1 commented Apr 12, 2017

It's similar for LCR:
Known candidates for Liverpool City Region in the Liverpool City Region

I suspect the only way to standardise this for all elections would be to include a some post-type text, eg:
Known candidates for Mayor of Liverpool City Region in the Liverpool City Region Combined Authority
Post-type text would need two words to support: Mayor of; Councillor for; MP for; etc.

Anyway, I came back to highlight a Liverpool by-election - this search should also lead to this by-election.

@symroe
Copy link
Member

symroe commented Apr 12, 2017

Agreed on names, see #67

I'll look at the by-election…

@symroe
Copy link
Member

symroe commented Apr 12, 2017

By-election: this is a bug with EveryElection where it's not attaching geographies to newly created elections.

I'll create an issue over there for this.

@symroe
Copy link
Member

symroe commented Apr 12, 2017

(Oh, and it's fixed now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants