Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elections used for statistic comparisons aren't helpful #106

Closed
mhl opened this issue Apr 20, 2017 · 2 comments
Closed

elections used for statistic comparisons aren't helpful #106

mhl opened this issue Apr 20, 2017 · 2 comments

Comments

@mhl
Copy link
Collaborator

mhl commented Apr 20, 2017

The numbers page is meant to show you comparisons of the numbers with previous elections of the same "type" (broadly - this will need to be better defined in fixing this problem). This is currently sometimes unhelpful, e.g.:

comparisonns

e.g. 2:

other-comparisons

The best elections to compare the 2017 general election to are those in 2015 and 2010. It might be best to have to explicitly link elections that should be compared like this. (This might be linked to: #103 )

@jf1
Copy link

jf1 commented Apr 20, 2017

This issue also suffers from the non-specific descriptors problem #67

'Copeland' would be better as 'Copeland UK Parliament by-election on February 23 2017'

If there'll be a flag for election/by-election (as I think there needs to be) then the comparisons system could consider only elections.

That said, now that DC generally lists all candidates for elections it's covering, is there any benefit from these comparisons? (I've always preferred a counter for locked posts, eg x/650 for June 8).

@andylolz
Copy link
Contributor

andylolz commented Apr 21, 2017

Hacky data fix:

So, this code uses for_post_role to determine if elections are related (i.e. one is a prior version of another).

So the quick hack here is to change the for_post_role of ‘parl.2017-06-08’ to ‘Member of Parliament’ (to match GE2010 and GE2015), and then change the ‘for_post_role’ of the Brightside and Ogmore by-elections to ‘UK parliament’ (to match the three other by-elections..)

The more general problem, it seems, is that short of inspecting IDs, there doesn’t seem to be a way to tell a general election from a parliamentary by-election? Is that true?

EDIT: Just spotted @jf1 already pointed this last bit out!

If there'll be a flag for election/by-election (as I think there needs to be)

mhl added a commit that referenced this issue Apr 27, 2017
These comparisons were introduced when we just had the 2010 and 2015
UK elections on the site. Unfortunately, the code doesn't work now that
there are also local election and by-elections in the database. It's
better to just remove this feature than to present bizarre comparisons
to users.  The implementation would need to be completely rethought,
and that's very low priority compared to the other things we're trying
to get done in time for the 2017 General Election.

This is an alternative to fixing the problems described in #106
@symroe symroe closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants