Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language choice element #15

Open
alexdutton opened this issue Mar 16, 2021 · 2 comments
Open

Language choice element #15

alexdutton opened this issue Mar 16, 2021 · 2 comments

Comments

@alexdutton
Copy link

Issue and Steps to Reproduce

WDIV is targeting having a Welsh-language translation. The design system doesn't support any standard way for a user to explicitly choose a language

Expected

Somewhere there should be an optional design element for choosing a language. For WDIV we'll probably do an English / Cymraeg element in the top-right of the header bar for now, even though that would clash with the general placement of the top nav.

@GeoWill
Copy link
Contributor

GeoWill commented Mar 17, 2021

WDIV implementation happening here: DemocracyClub/UK-Polling-Stations#3188

alexdutton added a commit to DemocracyClub/UK-Polling-Stations that referenced this issue Mar 30, 2021
alexdutton added a commit to DemocracyClub/UK-Polling-Stations that referenced this issue Apr 1, 2021
@alexdutton
Copy link
Author

@Heydon That looks great! I've copied it across into the UK-Polling-Stations at DemocracyClub/UK-Polling-Stations#3188 (see screenshots). As the Django set_language view takes a POST, I've replaced the <a> elements with <button>s, and added this:

  button {
    @include fontMain;
    border: 0;
    margin: 0;
    padding: 0;
    text-decoration: underline;
  }

to make it all look the same :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants