Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for notifications dialog #306

Open
chris48s opened this issue Nov 18, 2019 · 0 comments
Open

Translations for notifications dialog #306

chris48s opened this issue Nov 18, 2019 · 0 comments

Comments

@chris48s
Copy link
Member

At the moment, we aren't translating the button text on the notifications dialog:

<a
className="dc-btn-secondary"
target="_blank"
rel="noopener noreferrer"
title={'Read more information about this ' + props.title}
href={props.url}
>
Read More
</a>

This sort of doesn't matter in that the rest of the text in the dialog ( props.detail and props.title ) comes from the API and we won't have translations for that either, so if all the other text in the dialog is in English regardless of the user's language preference its not a massive issue that the button is too.

Need to think about how to deal with this situation..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant