Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Playwright tests for new ID legislation #5312

Open
Bekabyx opened this issue Mar 17, 2023 · 0 comments
Open

Update Playwright tests for new ID legislation #5312

Bekabyx opened this issue Mar 17, 2023 · 0 comments

Comments

@Bekabyx
Copy link
Contributor

Bekabyx commented Mar 17, 2023

I had problems running Playwright on my machine and I exceeded a sensible timebox to get it working. This meant I couldn't update the e2e tests for the changes in PR #5275

Aside from issues running Playwright, I wasn't sure how to add tests which rely on new datasets because the way we use PW currently is based off of the legacy cassettes from when we used Harvest. I don't have knowledge of how these were generated or how to make new ones. @GeoWill has ideas on this: "I wonder if we can move to a mixture of mocking the API calls, and using HTTP Archive Files - which playwright seems to be set up to work with. (API mocking and HAR files docs)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant