Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues uploading when there's no election date #5266

Open
GeoWill opened this issue Mar 15, 2023 · 0 comments
Open

Issues uploading when there's no election date #5266

GeoWill opened this issue Mar 15, 2023 · 0 comments

Comments

@GeoWill
Copy link
Collaborator

GeoWill commented Mar 15, 2023

Issue and Steps to Reproduce

When uploading a file for a council with no election (go to /uploads/upload_files/<reg-code>/) the user sees 'something's gone wrong', while we just raise a 500, because we tried to create an Upload instance with no election date. Example.

The fix for this is probably to do something around where we're setting the election date, and not let the user even push the upload button - instead we should say 'we don't know about any upcoming elections' please tell us...'.

Alternatively we could not even let anything happen if UPCOMING_ELECTION_DATES is empty. Maybe this is better 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant