Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve TypeError for py3.9 #183

Closed
veenstrajelmer opened this issue Dec 4, 2023 · 1 comment · Fixed by #185
Closed

Solve TypeError for py3.9 #183

veenstrajelmer opened this issue Dec 4, 2023 · 1 comment · Fixed by #185

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Dec 4, 2023 •
edited
Loading

Commit 1aa1564 results in TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'. This only happens on python 3.9, but it is not catched by github testing since pixi uses py 3.11. The linked PR illustrates the issue but is probably not the best way to go forward.

Related: I think dask and pymetis should be added to pyproject.toml under project.optional-dependencies.all.
@veenstrajelmer veenstrajelmer changed the title Solve TypeError introduced by FloatArray | None Solve TypeError for py3.9 Dec 4, 2023
@veenstrajelmer veenstrajelmer linked a pull request Dec 4, 2023 that will close this issue
Solve TypeError for py39 #184
Closed
@Huite
Copy link
Collaborator

Huite commented Dec 4, 2023

Should be solved by from __future__ import annotations I think.

@veenstrajelmer veenstrajelmer linked a pull request Dec 4, 2023 that will close this issue
WIP: Run multiple Python versions during tests #185
Merged
@Huite Huite closed this as completed in #185 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Huite @veenstrajelmer