Closed
Description
With the introduction of model validation, users now have some good feedback of what is wrong to their model, for example a model that I recently imported:
E imod.schemata.ValidationError:
E Simulation validation status:
E * imported_model model:
E * riv-2riv package:
E * stage:
E * not all values comply with criterion: >= bottom_elevation
E * riv-3riv package:
E * stage:
E * not all values comply with criterion: >= bottom_elevation
E * riv-5riv package:
E * stage:
E * not all values comply with criterion: >= bottom_elevation
E * conductance:
E * nodata is not aligned with stage
E * bottom_elevation:
E * nodata is not aligned with stage
E not all values comply with criterion: >= bottom
E * riv-5drn package:
E * conductance:
E * nodata is not aligned with elevation
However there is not so much guidance on how to fix things. To help them, I think we could create some cleanup utilities, which need to be very well documented on how they clean up data. Users then still need to make the calls to the functions themselves, so that they are aware what they are doing.
Requirements
- Create a namespace, like
imod.cleanup
for these utilities, becomes part of public API - Extend ValidationError messages with hints to the cleanup functions #1276
- Well documented cleanup utilities
- Add utilities for:
- Masking all cells in inactive model domain.
mask_all_models
basically does this. - BC: Aligning nodata for a boundary condition
- RIV: Setting stage above bottom_elevation
- RIV/DRN: Setting stage/elevation equal to model bottom
- More?
- Masking all cells in inactive model domain.
- Add example showcasing cleanup utilities #1273
- Add cleanup utility wells #1187
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
✅ Done