Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelbuilder improve ERA5 experience #1072

Closed
7 tasks done
veenstrajelmer opened this issue Jan 18, 2025 · 0 comments · Fixed by #1073
Closed
7 tasks done

modelbuilder improve ERA5 experience #1072

veenstrajelmer opened this issue Jan 18, 2025 · 0 comments · Fixed by #1073

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jan 18, 2025

A non-wgs84 grid resulted in the following Delft3D FM error:

** INFO   : External Forcing or Initialising 'airpressure_windx_windy_charnock' from file 'era5_msl_u10n_v10n_chnk_20030301to20030331_ERA5.nc'.
** WARNING: Variable 'air_pressure' in NetCDF file 'era5_msl_u10n_v10n_chnk_20030301to20030331_ERA5.nc requires 'projection_x_coordinate' and 'projection_y_coordinate'.
** WARNING: Variable 'air_pressure' in NetCDF file 'era5_msl_u10n_v10n_chnk_20030301to20030331_ERA5.nc coordinates variable valid_time referenced but not found
** ERROR  : flow_initexternalforcings: Error while initializing quantity: airpressure_windx_windy_charnock . Check preceding log lines for details.

This was due to the fact that the software got a cartesian grid and expected a cartesian ERA5 netcdf, which was not the case. To avoid this, there are some steps to be done.

Todo:

  • add comment to modelbuilder notebook: "only EPSG:4326 is supported by the CMEMS/ERA5 download functions"
  • update docstring of dfmt.preprocess_ERA5() to state current relevance (expver dim and scaling/offset not present anymore, but was for some intermediate files) (valid_time renaming necessary to be consistent with old downloads)
  • request valid-time rename to time at ecmwf forum >> never mind
  • warning if era5 expver dimension is found? Or if scaling/offset is found? >> not needed, will probably be handled fine and preprocess_ERA5 is now optional.
  • add safeguard to `dfmt.download_ERA5() for case with date_min>date_max
  • rename valid_time in coordinates, this avoids confusion when supplying cartesian network >> no, too much effort compared to the benefit
  • notebook: add lon-min etc input arguments to function (now order of passing matters)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant