Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream merge introduces several regressions #2819

Open
Samsterious opened this issue Jan 30, 2025 · 1 comment
Open

Upstream merge introduces several regressions #2819

Samsterious opened this issue Jan 30, 2025 · 1 comment
Assignees
Labels
Changes: C# Changes any cs files Priority: 1-Urgent Must be resolved immediately size/S 16-63 lines

Comments

@Samsterious
Copy link
Contributor

Description

There are several bugs introduced in the recent upstream merge that may warrant a revert of the UIv2 update until upstream has done more work to improve the quality of this change.

  • Upon reaching the maximum number of open inventories, it becomes impossible to open any other inventories (previous behavior: an older window is closed and replaced with the new one)
  • Inventory window positions are reset whenever opening a new inventory, even containers within a currently-open inventory
  • Recently-inserted items have duplicate stars, rendering it unclear which items will be quick-grabbed via hotkeys
  • Silicon laws cannot be viewed in the view laws UI

Screenshots
Image
Image

@github-actions github-actions bot added the S: Untriaged This issue or PR needs labelling label Jan 30, 2025
@deltanedas
Copy link
Member

for first thing its not impossible just annoying, you have to manually close a window first

positions and stars could be easy to fix

laws has a fix pr open

@deltanedas deltanedas added Changes: C# Changes any cs files Priority: 1-Urgent Must be resolved immediately size/S 16-63 lines and removed S: Untriaged This issue or PR needs labelling labels Jan 31, 2025
@deltanedas deltanedas self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Priority: 1-Urgent Must be resolved immediately size/S 16-63 lines
Projects
None yet
Development

No branches or pull requests

2 participants