Closed findings not shown if created in a different month than mitigated

[jugalb-icpl]

📌 Issue: Closed Findings Not Shown Unless Created in Same Month

🐞 Problem

In the simple_metrics dashboard, the "Closed" count only includes findings that were both created and mitigated in the same month. This leads to inaccurate reporting, as any findings mitigated in the selected month — but created earlier — are completely excluded.

🔍 Root Cause

The code filters findings using only the date (created date), like so:

total = Finding.objects.filter(
    test__engagement__product__prod_type=pt,
    verified=True,
    false_p=False,
    duplicate=False,
    out_of_scope=False,
    date__month=now.month,
    date__year=now.year,
)

Later, it tries to count "Closed" findings with:

if f.mitigated and f.mitigated.year == now.year and f.mitigated.month == now.month:
    total_closed.append(f)

However, since the total queryset only includes findings created in the selected month, it misses any that were created earlier but mitigated during the selected month.

Expected Behavior

The "Closed" count should include all findings that were mitigated (closed) in the selected month/year, regardless of when they were created.

[valentijnscholten]

@Maffooch I think this makes sense, just checking if you agree?

[valentijnscholten]

This is fixed via #12599