Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for Python 3.11 #540

Open
gcroci2 opened this issue Jan 3, 2024 · 3 comments · May be fixed by #634
Open

Fix build for Python 3.11 #540

gcroci2 opened this issue Jan 3, 2024 · 3 comments · May be fixed by #634
Assignees
Labels
blocked bug Something isn't working CI continuous integration

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented Jan 3, 2024

I opened an issue in torch repository: pytorch/pytorch#116707.

If it's not picked up soon, we could think about work arounds, such as regenerating the problematic files with pytest fixtures (it may be that saving AND loading files with Python 3.11 solves the issue).

@gcroci2 gcroci2 added bug Something isn't working priority Solve this first CI continuous integration labels Jan 3, 2024
@gcroci2 gcroci2 linked a pull request Jan 19, 2024 that will close this issue
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Jan 24, 2024

In PR #549 I removed Python 3.11 from the CI, until this issue won't be solved.

While fixing this issue, remember to switch the python requirement to python>=3.10,<3.12 in the yml file, so that then the CI can set both 3.10 and 3.11 according to the different build.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Mar 29, 2024
@gcroci2 gcroci2 removed the stale issue not touched from too much time label Jul 9, 2024
@gcroci2 gcroci2 linked a pull request Aug 1, 2024 that will close this issue
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Aug 1, 2024

As of 31/07/2024, I tried to re-add the python 3.11 version to the CI and it is still failing as reported above and in pytorch/pytorch#116707.

To try to solve this:

  • I tried to create locally (mac) an env based on python 3.11. All tests passed.
  • I tried to upload the pretrained models' files that I had locally, to be sure that the version on the remote was not outdated. I changed names of the files to be sure this was happening, but tests for 3.11 are still failing. This makes me think that it can be an issue related to python 3.11 for linux OS only (the tests using 3.11 with 3.10-generated files pass on my mac, see above).
  • Do the same on snellius, so that I can follow the same commands as in the action.yml file.
    • Snellius is under maintainance, so for now this is not possible.
  • Do it on a docker container. Compare the 3.10 installation (currently in place) with the 3.11 one by running the same tests with the same files (generated with 3.10) in both. Blocked by Fix Dockerfile build and add GitHub action for testing it #529
  • [Only if tests didn't pass] Try to regenerate the pretrained models using a conda env with python 3.11 instead of 3.10. Then re-run the tests for both python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working CI continuous integration
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

1 participant