Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make _set_feature_modules to return ModuleType objects #512

Open
DaniBodor opened this issue Oct 9, 2023 · 1 comment
Open

make _set_feature_modules to return ModuleType objects #512

DaniBodor opened this issue Oct 9, 2023 · 1 comment
Labels
nice to have low priority issues stale issue not touched from too much time

Comments

@DaniBodor
Copy link
Collaborator

see #492 (comment)

in query.py
# TODO: I would prefer if _set_feature_modules would return a list of ModuleType instead of str,
# but this leads to an exception in the pool function in QueryCollection.process, that I don't know how to solve.
# Tests are currently passing ModuleTypes directly, which is clearer than passing strings
# and is the reason I am allowing both input types.

@DaniBodor DaniBodor added the nice to have low priority issues label Oct 9, 2023
@DaniBodor DaniBodor changed the title refactor _set_feature_modules to return ModuleType objects make _set_feature_modules to return ModuleType objects Oct 9, 2023
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Nov 10, 2023
@gcroci2 gcroci2 added SS and removed SS labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have low priority issues stale issue not touched from too much time
Development

No branches or pull requests

2 participants