Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueErrors raised in Variant tutorials #494

Closed
DaniBodor opened this issue Sep 6, 2023 · 6 comments
Closed

ValueErrors raised in Variant tutorials #494

DaniBodor opened this issue Sep 6, 2023 · 6 comments
Assignees
@gcroci2
Labels
bug Something isn't working duplicate This issue or pull request already exists stale issue not touched from too much time

Comments

@DaniBodor
Copy link
Collaborator

I noticed that in processing the querycollection (for both atomic and residue), a number of ValueErrors are raised. The code doesn't crash though.

We should investigate why these are raised and whether it is ok that processing does not terminate when these are found.
@DaniBodor DaniBodor added the bug Something isn't working label Sep 6, 2023
@DaniBodor
Copy link
Collaborator Author

somewhat related:
we should decrease the distance_cutoff and radius in both atomic level tutorials to 3.0, otherwise it takes way too long to generate the data (took >25 mins for me and then I stopped it).

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Oct 9, 2023
@DaniBodor DaniBodor removed the stale issue not touched from too much time label Oct 9, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Nov 10, 2023
@DaniBodor
Copy link
Collaborator Author

I wonder whether this is related to #520

@DaniBodor DaniBodor removed the stale issue not touched from too much time label Nov 14, 2023
@DaniBodor DaniBodor mentioned this issue Nov 28, 2023
Merged
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Jan 17, 2024
@gcroci2 gcroci2 added the duplicate This issue or pull request already exists label Jun 27, 2024
@gcroci2
Copy link
Collaborator

gcroci2 commented Jun 27, 2024

#613 is a duplicated of this issue. We will fix this in #613

@gcroci2 gcroci2 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@gcroci2 gcroci2 moved this to Done in Development Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcroci2 gcroci2

Labels
bug Something isn't working duplicate This issue or pull request already exists stale issue not touched from too much time
Projects
Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaniBodor @gcroci2