Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is _get_atom_node_key obsolete? #490

Closed
DaniBodor opened this issue Sep 6, 2023 · 5 comments · Fixed by #492
Closed

Is _get_atom_node_key obsolete? #490

DaniBodor opened this issue Sep 6, 2023 · 5 comments · Fixed by #492
Assignees
@cbaakman
Labels
needs info more information is needed stale issue not touched from too much time

Comments

@DaniBodor
Copy link
Collaborator

This method is part of SingleResidueVariantAtomicQuery class, but does not seem to be used anywhere. @cbaakman , do you know if it is still needed for anything?
@DaniBodor DaniBodor added the needs info more information is needed label Sep 6, 2023
@cbaakman
Copy link
Collaborator

cbaakman commented Sep 7, 2023

No, it's not needed anymore. I say we remove it.

@DaniBodor
Copy link
Collaborator Author

DaniBodor commented Sep 8, 2023 •
edited
Loading

will do while working on #480

This was referenced Sep 6, 2023
Closed
Closed
@DaniBodor DaniBodor linked a pull request Sep 8, 2023 that will close this issue
refactor: Query classes and related code #489
Closed
@DaniBodor DaniBodor mentioned this issue Sep 8, 2023
Merged
20 tasks
@DaniBodor DaniBodor linked a pull request Sep 8, 2023 that will close this issue
refactor: Query classes and related code #492
Merged
20 tasks
DaniBodor added a commit that referenced this issue Sep 11, 2023
@DaniBodor
remove _get_atom_node_key method
aeee081 
as discussed in issue #490
DaniBodor added a commit that referenced this issue Sep 11, 2023
@DaniBodor
remove _get_atom_node_key method
69845b4 
as discussed in issue #490
DaniBodor added a commit that referenced this issue Sep 11, 2023
@DaniBodor
remove _get_atom_node_key method
4f67498 
as discussed in issue #490
DaniBodor added a commit that referenced this issue Sep 11, 2023
@DaniBodor
remove _get_atom_node_key method
9cdecf8 
as discussed in issue #490
DaniBodor added a commit that referenced this issue Sep 18, 2023
@DaniBodor
remove _get_atom_node_key method
baa739f 
as discussed in issue #490
DaniBodor added a commit that referenced this issue Sep 22, 2023
@DaniBodor
remove _get_atom_node_key method
d6dd686 
as discussed in issue #490
@DaniBodor DaniBodor mentioned this issue Sep 23, 2023
Closed
2 tasks
DaniBodor added a commit that referenced this issue Sep 23, 2023
@DaniBodor
remove _get_atom_node_key method
2f08eee 
as discussed in issue #490
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Oct 9, 2023
@gcroci2
Copy link
Collaborator

gcroci2 commented Feb 19, 2024

Can we close this? @DaniBodor

@DaniBodor
Copy link
Collaborator Author

yes, must have missed this when closing #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbaakman cbaakman

Labels
needs info more information is needed stale issue not touched from too much time
Projects
None yet
Milestone
No milestone
3 participants
@cbaakman @DaniBodor @gcroci2