Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create feature classes #486

Open
DaniBodor opened this issue Sep 5, 2023 · 2 comments
Open

Create feature classes #486

DaniBodor opened this issue Sep 5, 2023 · 2 comments
Labels
nice to have low priority issues stale issue not touched from too much time

Comments

@DaniBodor
Copy link
Collaborator

Build a parent class for DeepRankFeature and then use this to create child classes for each independent feature, that contain an add_feature function.
This allows for much better control when building the graph as well as makes a "guideline" for custom features.

Might be too much effort to convert current structure, but would def be an improvement.

@DaniBodor DaniBodor added the nice to have low priority issues label Sep 5, 2023
@DaniBodor
Copy link
Collaborator Author

This will probably be useful once we start making new features for new data types (such as nucleic acids, etc).

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Oct 9, 2023
@gcroci2 gcroci2 added SS and removed SS labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have low priority issues stale issue not touched from too much time
Development

No branches or pull requests

2 participants