Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate class diagrams #251

Closed
gcroci2 opened this issue Nov 22, 2022 · 5 comments · Fixed by #519
Closed

Regenerate class diagrams #251

gcroci2 opened this issue Nov 22, 2022 · 5 comments · Fixed by #519
Assignees
@gcroci2
Labels
class diagram new classes/functions to complete the class diagram docs Improvements or additions to documentation priority Solve this first tools tools for users to interact with deeprank

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented Nov 22, 2022 •
edited by DaniBodor
Loading

Note that the sh script states:

Run the script in the deeprank-core/deeprankcore

Not sure if it works as intended if run from tools folder.

Blocked by #181, #236, #231
@gcroci2 gcroci2 self-assigned this Nov 22, 2022
@DaniBodor DaniBodor added tools tools for users to interact with deeprank blocked labels Nov 23, 2022
@gcroci2 gcroci2 added the priority Solve this first label Dec 7, 2022
@DaniBodor DaniBodor added docs Improvements or additions to documentation class diagram new classes/functions to complete the class diagram labels Dec 8, 2022
@DaniBodor
Copy link
Collaborator

@gcroci2 , why is this blocked?
Does it need to be recreated each time we adjust any class in the package?

@gcroci2
Copy link
Collaborator Author

gcroci2 commented Dec 8, 2022

@gcroci2 , why is this blocked? Does it need to be recreated each time we adjust any class in the package?

No absolutely, but I was waiting for reorganizing the Trainer class first. Finished that, we can regenerate the class diagram.

@gcroci2 gcroci2 removed the blocked label Dec 13, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale issue not touched from too much time label Jan 13, 2023
@gcroci2 gcroci2 removed the stale issue not touched from too much time label Jan 13, 2023
@gcroci2 gcroci2 added development and removed priority Solve this first labels Apr 26, 2023
@gcroci2 gcroci2 added priority Solve this first and removed development labels Jun 12, 2023
@gcroci2 gcroci2 mentioned this issue Sep 6, 2023
Closed
@gcroci2 gcroci2 added the blocked label Sep 6, 2023
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Sep 6, 2023

Waiting for #480 to be over for plotting the most updated situation

@gcroci2 gcroci2 removed the blocked label Sep 26, 2023
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Nov 2, 2023 •
edited
Loading

I generated new diagrams using https://www.gituml.com/, separating them in two: one for the data processing phase, and another one for the ML pipeline (training + testing + export). See PR #519

@gcroci2 gcroci2 linked a pull request Nov 2, 2023 that will close this issue
Regenerate class diagrams #519
Merged
@gcroci2 gcroci2 closed this as completed Nov 9, 2023
@gcroci2 gcroci2 added SS and removed SS labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcroci2 gcroci2

Labels
class diagram new classes/functions to complete the class diagram docs Improvements or additions to documentation priority Solve this first tools tools for users to interact with deeprank
Projects
SSP: Diversifying molecule coverage
Status: Done
Documentation - Generalization 3
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Regenerate class diagrams DeepRank/deeprank2
2 participants
@DaniBodor @gcroci2