New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access modifiers #1

Open

aaron345678 opened this issue Nov 6, 2024 · 0 comments

aaron345678 commented Nov 6, 2024

Make your variables private. It's not super duper code breaking but its genuinely good practice. Example:

mateam2-/src/main/java/org/carlmontrobotics/subsystems/Drivetrain.java

Lines 15 to 16 in d8b645a

    
           CANSparkMax rightWheels = MotorControllerFactory.createSparkMax(3, MotorConfig.NEO); 
        
           CANSparkMax leftWheels = MotorControllerFactory.createSparkMax(2, MotorConfig.NEO);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment