Skip to content
This repository has been archived by the owner on Sep 14, 2019. It is now read-only.

Intake does not intake cubes after the first one #110

Open
brettle opened this issue Jun 16, 2018 · 5 comments
Open

Intake does not intake cubes after the first one #110

brettle opened this issue Jun 16, 2018 · 5 comments
Assignees

Comments

@brettle
Copy link
Member

brettle commented Jun 16, 2018

Mackenzi, Alice, Josh and I noticed this at Maker Faire. We could intake one cube and eject it, but then could not intake a second cube (the wheels would not spin in the intake direction when pressing the associated button). The problem would go away if we restarted the code though, so it was clearly a code problem. My theory is that it thinks a cube is still in the intake even after it has been ejected.

@brettle
Copy link
Member Author

brettle commented Jun 16, 2018

@dfang314
Copy link
Contributor

dfang314 commented Sep 6, 2018

Resolved through latest DriverStationComputer commit.

@dfang314 dfang314 closed this as completed Sep 6, 2018
@dfang314 dfang314 reopened this Sep 6, 2018
@brettle
Copy link
Member Author

brettle commented Sep 7, 2018

Why was this reopened?

@dfang314
Copy link
Contributor

dfang314 commented Sep 7, 2018

I assumed that we wanted to test in a competition environment to make sure it is resolved before we close it.

@brettle
Copy link
Member Author

brettle commented Sep 8, 2018

If you were able to reliably reproduce the problem before the fix and attempts to reproduce the problem after the fix reliably failed, you should close the issue. If it comes up again in the future, we can always reopen it.

As a side note, when closing an issue, it's best to mention the specific commit(s) which contain the fix so that they can be reviewed. For example, this bug was fixed by dccf8a7.

Also, when writing the commit message, if you write #110 instead of "Issue 110", GitHub will make that a link to the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants