Triton Puzzle was broken (by a recent change?)

[Matagi1996]

When trying a colab notebook here:
https://colab.research.google.com/github/srush/Triton-Puzzles/blob/main/Triton-Puzzles.ipynb#scrollTo=_981RFRp4Avz

I got a early error with regards to kwargs not beeing passed while following the notebook:
TypeError Traceback (most recent call last)
in <cell line: 11>()
9 print(x)
10
---> 11 triton_viz.trace(demo)[(1, 1, 1)](torch.ones(4, 4))
12 triton_viz.launch()

3 frames
/usr/local/lib/python3.10/dist-packages/triton_viz/interpreter.py in _grid_executor_call(self, *args_dev, **kwargs)
135
136 def _grid_executor_call(self, *args_dev, **kwargs):
--> 137 args_hst = self._init_args_hst(args_dev)
138 # Removes reserved keywords from kwargs
139 kwargs = {k: v for k, v in kwargs.items() if k not in RESERVED_KWS}

TypeError: GridExecutor._init_args_hst() missing 1 required positional argument: 'kwargs'

I noticed that the file recently changed but see no apparent cause of the bug, so maybe the colab notebook is at fault here.

[Jokeren]

@mark14wu Please fix

[why-in-Shanghaitech]

It is an update from triton: triton-lang/triton#3777

[Jokeren]

By looking at the problem again, I think triton-viz/main should have fixed it already. Maybe there's a mismatch between the triton wheel you're using and what the puzzle is using

[why-in-Shanghaitech]

By looking at the problem again, I think triton-viz/main should have fixed it already. Maybe there's a mismatch between the triton wheel you're using and what the puzzle is using

That's true. The puzzle is using v1 of triton-viz.

[distributedstatemachine]

I built off main , and still ran into the same issue . What am i doing wrong ?

%pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz.git@main

[Jokeren]

I've offloaded this problem to @mark14wu

[mark14wu]

Let me have a look.

[why-in-Shanghaitech]

I built off main , and still ran into the same issue . What am i doing wrong ?

%pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz.git@main

I solve this by restarting the notebook, then %pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz.git

[mark14wu]

I tried several settings.
%pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz@v1 doesn't work, while
%pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz@main and
%pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz works pretty good. I am planning to update the notebook in Triton-Puzzle repo.

[mark14wu]

I built off main , and still ran into the same issue . What am i doing wrong ?

%pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz.git@main

In the colab notebook, you can try Runtime -> Disconnect and delete runtime , and re-run the code again.

[Jokeren]

I am planning to update the notebook in Triton-Puzzle repo

Thanks. Please pin Sasha when you create a PR and cc me

[mark14wu]

I built off main , and still ran into the same issue . What am i doing wrong ?

%pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz.git@main

In the colab notebook, you can try Runtime -> Disconnect and delete runtime , and re-run the code again.

This is because while pip installing triton-viz@main, somehow it doesn't overwrite the buggy file interpreter.py introduced by triton-viz@v1

[Jokeren]

Maybe we should make a release like v1.1 and change the link to pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz@v1.1

[mark14wu]

Maybe we should make a release like v1.1 and change the link to pip install git+https://github.com/Deep-Learning-Profiling-Tools/triton-viz@v1.1

Agreed.