Why set email and user.name for every repository?

[lechner]

Hi, should user.name and email really be added to every repository? I have both in my ~/.gitconfig? An alternative could be to warn if neither is available, and maybe add them (preferably globally) fromDEB_FULLNAME and DEB_EMAIL.

I stumbled on the issue because of a bug in golang-github-tcnksm-go-gitconfig, where tests were not properly isolated. (That merge request is here.) While this issue is not necessarily a bug, it may make it more difficult to change an email. Please let me know your favorite way to resolve, and I will submit a merge request. Thank you!

dh-make-golang/make.go

Lines 296 to 306 in f0afc0f

	if debianName := getDebianName(); debianName != "TODO" {
	if err := runGitCommandIn(dir, "config", "user.name", debianName); err != nil {
	return dir, err
	}
	}
	if debianEmail := getDebianEmail(); debianEmail != "TODO" {
	if err := runGitCommandIn(dir, "config", "user.email", debianEmail); err != nil {
	return dir, err
	}
	}

[stapelberg]

I have a different user/email in my global git config, so setting the debian ones for debian repositories only makes sense in my world.

I would accept a patch which skips this behavior when the global git config already contains the correct name, though :)

[lechner]

Great! Would you mind if I use golang-github-tcnksm-go-gitconfig, which I recently got to know quite well? It is a prerequisite for git-lab and will probably be around for a while. Thank you!

[stapelberg]

Isn’t shelling out to the git tool sufficient for this?

[lechner]

Doing it by hand will add this code. It is totally your call. Thank you!

func execGitConfig(args ...string) (string, error) {
	gitArgs := append([]string{"config", "--get", "--null"}, args...)
	var stdout bytes.Buffer
	cmd := exec.Command("git", gitArgs...)
	cmd.Stdout = &stdout
	cmd.Stderr = ioutil.Discard

	err := cmd.Run()
	if exitError, ok := err.(*exec.ExitError); ok {
		if waitStatus, ok := exitError.Sys().(syscall.WaitStatus); ok {
			if waitStatus.ExitStatus() == 1 {
				return "", &ErrNotFound{Key: args[len(args)-1]}
			}
		}
		return "", err
	}

	return strings.TrimRight(stdout.String(), "\000"), nil
}

[stapelberg]

Yeah, I think I’d prefer that code (modulo some comments which we can discuss over a pull request) over an additional dependency :)

[lechner]

#106