Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception: Quickly scrolling languages causes crash #56

Open
perryfranks opened this issue Jun 19, 2022 · 2 comments
Open

Unhandled exception: Quickly scrolling languages causes crash #56

perryfranks opened this issue Jun 19, 2022 · 2 comments
Labels
bug Something isn't working needs more info The issue needs further information in order to be tackled efficiently

Comments

@perryfranks
Copy link

  • Description: Quickly scrolling the language selection in the launcher settings causes a crash consistently. This occurs with both the mouse wheel, keyboard, and by selecting languages normally with the mouse and quickly moving between languages. I suspect this is from loading multiple languages to quickly. Sometimes it can be difficult to get the language selection to change with the mouse wheel. This error originally occurred with launcher version 1.6.5 under the old repository by remyroy although that was only tested with using the mouse wheel and second OS version listed below.
  • Error reproduction: Quickly change the selected language under Settings -> Launcher -> Language
  • Version: 1.6.6
  • OS: Windows-10-10.0.19043-SP0 (64-bit) and Windows-10-10.0.22000-SP0 (64-bit) (bug only tested with mouse scrolling)
  • Type: <class 'AttributeError'>
  • Value: 'NoneType' object has no attribute 'seek'
  • Traceback:
  File "C:\Users\disco\AppData\Local\Programs\CDDA Game Launcher\cddagl\ui\views\main.py", line 3055, in lb_http_finished
    self.lb_html.seek(0)

@HenicTheSodgehog
Copy link

Can confirm, replicating the issue gives me the following error:

Version: 1.6.6
OS: Windows-10-10.0.17763-SP0 (64-bit)
Type: <class 'KeyError'>
Value: 'items'
Traceback:

File "X:\XXX\cddagl\ui\views\settings.py", line 203, in locale_combo_changed

update_group_box.refresh_builds()
File "X:\XXX\cddagl\ui\views\main.py", line 3266, in refresh_builds
self.refresh_changelog()
File "X:\XXX\cddagl\ui\views\main.py", line 3286, in refresh_changelog
for entry in changelog_data["items"]:

@DazedNConfused- DazedNConfused- added the bug Something isn't working label Jun 21, 2022
@DazedNConfused-
Copy link
Owner

Howdy! Thanks for the report.

Despite my best efforts, I am unable to replicate this issue on my local machine. Which is surprising honestly, for my potato laptop is a far cry from what could be considered a "performant machine". I even tried to rapidly scroll & change the languages as fast as my mouse wheel could go, and I couldn't make the launcher crash at all not even once.

Furthermore, these two incidences seem to have failed on different lines, despite the trigger similarities. So yep, this may turn to be a tricky one allright...

@DazedNConfused- DazedNConfused- added the needs more info The issue needs further information in order to be tackled efficiently label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info The issue needs further information in order to be tackled efficiently
Projects
None yet
Development

No branches or pull requests

3 participants