Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Full screen graphs not working in mobile version #269

Open
aryiu opened this issue Apr 10, 2024 · 3 comments
Open

[BUG] Full screen graphs not working in mobile version #269

aryiu opened this issue Apr 10, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@aryiu
Copy link

aryiu commented Apr 10, 2024

Describe the bug
When you open WDC on the phone version, the full screen button in graphs is not working (Safari on iOS). I don't know if it's the expected behaviour of the Carbon components.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a graph in mobile version.
  2. Click on the full screen button.
  3. It doesn't do anything.

Expected behavior
When tapping on the full screen button, it should open the graph in full screen.

Additional context
https://carbondesignsystem.com/data-visualization/simple-charts/

@aryiu aryiu added the bug Something isn't working label Apr 10, 2024
@Daveiano
Copy link
Owner

@aryiu Are you using Safari on iOS?

@aryiu
Copy link
Author

aryiu commented Nov 24, 2024

@Daveiano Yes, as I said.

@Daveiano
Copy link
Owner

@Daveiano Yes, as I said.

Sorry, I completely missed that.

I did not know this yet but Safari (or I think iOS in general) does not support the Fullscreen API all other modern browsers support which I am using for the fullscreen feature.

I don't know of an easy way to implement a full-screen feature on iOS and I am afraid I will not put any time into that. Even the examples at https://carbondesignsystem.com/data-visualization/simple-charts/ do not have a fullscreen icon when accessed by an iPhone.

Sorry to say that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants