NodeCollection: Better error exception on adding items with same name

Author: alex-kulakov

Orm/Xtensive.Orm/Sql/Model/NodeCollection.cs

@@ -30,12 +30,18 @@ public class NodeCollection<TNode>: CollectionBaseSlim<TNode>
     /// <returns><see langword="True"/> if this instance is read-only; otherwise, <see langword="false"/>.</returns>
     public override bool IsReadOnly { get { return IsLocked || base.IsReadOnly; } }
 
-    /// <inheritdoc/>
+    /// <summary>
+    /// Adds item to collection.
+    /// </summary>
+    /// <param name="item">Item to add</param>
+    /// <exception cref="ArgumentException">The item with same name already exists in the collection</exception>
     public override void Add(TNode item)
     {
       base.Add(item);
-      if (!string.IsNullOrEmpty(item.GetNameInternal()))
-        nameIndex.Add(item.GetNameInternal(), item);
+      var name = item.GetNameInternal();
+      if (!string.IsNullOrEmpty(name) && !nameIndex.TryAdd(name, item)) {
+        throw new ArgumentException(string.Format(Strings.ExItemWithNameXAlreadyExists, name));
+      }
     }
 
     public override bool Remove(TNode item)