Minor changes

- summaries for files, types, type members
- small code improvements

Author: alex-kulakov

Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfiguration.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011-2024 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2012-2024 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2012.07.06
 
@@ -132,7 +132,7 @@ private static LocalizationConfiguration GetConfigurationFromSection(Configurati
     }
 
     /// <summary>
-    /// Loads <see cref="LocalizationConfiguration"/> from given configuration section of <paramref name="configurationRoot"/>.
+    /// Loads <see cref="LocalizationConfiguration"/> from given configuration section of <paramref name="configuration"/>.
     /// If section name is not provided <see cref="LocalizationConfiguration.DefaultSectionName"/> is used.
     /// </summary>
     /// <param name="configuration"><see cref="IConfiguration"/> of sections.</param>
@@ -142,17 +142,16 @@ public static LocalizationConfiguration Load(IConfiguration configuration, strin
     {
       ArgumentValidator.EnsureArgumentNotNull(configuration, nameof(configuration));
 
-      if (configuration is IConfigurationRoot configurationRoot)
+      if (configuration is IConfigurationRoot configurationRoot) {
         return new LocalizationConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
+      }
       else if (configuration is IConfigurationSection configurationSection) {
-        if (sectionName.IsNullOrEmpty())
-          return new LocalizationConfigurationReader().Read(configurationSection);
-        else {
-          return new LocalizationConfigurationReader().Read(configurationSection.GetSection(sectionName));
-        }
+        return sectionName.IsNullOrEmpty()
+          ? new LocalizationConfigurationReader().Read(configurationSection)
+          : new LocalizationConfigurationReader().Read(configurationSection.GetSection(sectionName));
       }
 
-      throw new NotSupportedException("Type of configuration is not supported");
+      throw new NotSupportedException("Type of configuration is not supported.");
     }
 
     /// <summary>

Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfigurationReader.cs

@@ -1,8 +1,6 @@
-// Copyright (C) 2011-2024 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
-// Created by: Dmitri Maximov
-// Created:    2012.07.06
+// Copyright (C) 2024 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 
 using System;
 using System.Globalization;
@@ -16,6 +14,9 @@ namespace Xtensive.Orm.Localization.Configuration
 {
   internal sealed class LocalizationConfigurationReader : IConfigurationSectionReader<LocalizationConfiguration>
   {
+    private const string DefaultCultureElementName = "DefaultCulture";
+    private const string CultureNameAttributeName = "name";
+
     public LocalizationConfiguration Read(IConfigurationSection configurationSection) => ReadInternal(configurationSection);
 
     public LocalizationConfiguration Read(IConfigurationSection configurationSection, string nameOfConfiguration) =>
@@ -33,14 +34,13 @@ public LocalizationConfiguration Read(IConfigurationRoot configurationRoot, stri
     public LocalizationConfiguration Read(IConfigurationRoot configurationRoot, string sectionName, string nameOfConfiguration) =>
       throw new NotSupportedException();
 
-    private const string DefaultCultureElementName = "DefaultCulture";
-    private const string CultureNameAttributeName = "name";
-
     private LocalizationConfiguration ReadInternal(IConfigurationSection configurationSection)
     {
       var defaultCultureSection = configurationSection.GetSection(DefaultCultureElementName);
-      if (defaultCultureSection == null)
-        return new LocalizationConfiguration() { DefaultCulture = Thread.CurrentThread.CurrentCulture };
+      var defaultCulture = Thread.CurrentThread.CurrentCulture;
+      if (defaultCultureSection == null) {
+        return new LocalizationConfiguration() { DefaultCulture = defaultCulture };
+      }
 
       var cultureName = defaultCultureSection.Value;
       if (cultureName == null) {
@@ -52,15 +52,16 @@ private LocalizationConfiguration ReadInternal(IConfigurationSection configurati
           }
         }
       }
-
-      if (cultureName.IsNullOrEmpty())
-        return new LocalizationConfiguration() { DefaultCulture = Thread.CurrentThread.CurrentCulture };
-      try {
-        return new LocalizationConfiguration() { DefaultCulture = new CultureInfo(cultureName) };
-      }
-      catch (CultureNotFoundException) {
-        return new LocalizationConfiguration() { DefaultCulture = Thread.CurrentThread.CurrentCulture };
+      if(!cultureName.IsNullOrEmpty()) {
+        try {
+          defaultCulture = CultureInfo.GetCultureInfo(cultureName);
+        }
+        catch(CultureNotFoundException) {
+          // swallow it, this is mark wrong culture name;
+        }
       }
+
+      return new LocalizationConfiguration() { DefaultCulture = defaultCulture };
     }
   }
 }

Extensions/Xtensive.Orm.Reprocessing/Configuration/ConfigurationSection.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.ComponentModel;
 using System.Configuration;
 
@@ -11,8 +11,9 @@ public class ConfigurationSection : System.Configuration.ConfigurationSection
   {
     /// <summary>
     /// Gets default section name for reprocessing configuration.
-    /// Value is "Xtensive.Reprocessing".
+    /// Value is "Xtensive.Orm.Reprocessing".
     /// </summary>
+    [Obsolete("Use ReprocessingConfiguration.DefaultSectionName instead")]
     public static readonly string DefaultSectionName = "Xtensive.Orm.Reprocessing";
 
     /// <summary>

Extensions/Xtensive.Orm.Reprocessing/Configuration/ReprocessingConfiguration.cs

@@ -11,6 +11,12 @@ namespace Xtensive.Orm.Reprocessing.Configuration
   /// </summary>
   public class ReprocessingConfiguration : ConfigurationBase
   {
+    /// <summary>
+    /// Gets default section name for reprocessing configuration.
+    /// Value is "Xtensive.Orm.Reprocessing".
+    /// </summary>
+    public static readonly string DefaultSectionName = "Xtensive.Orm.Reprocessing";
+
     /// <summary>
     /// Gets default value of the <see cref="DefaultTransactionOpenMode"/> property.
     /// </summary>
@@ -68,7 +74,7 @@ protected override void CopyFrom(ConfigurationBase source)
     /// <returns>The reprocessing configuration.</returns>
     public static ReprocessingConfiguration Load()
     {
-      return Load(ConfigurationSection.DefaultSectionName);
+      return Load(DefaultSectionName);
     }
 
     /// <summary>
@@ -89,7 +95,7 @@ public static ReprocessingConfiguration Load(string sectionName)
     /// <returns>The reprocessing configuration.</returns>
     public static ReprocessingConfiguration Load(System.Configuration.Configuration configuration)
     {
-      return Load(configuration, ConfigurationSection.DefaultSectionName);
+      return Load(configuration, DefaultSectionName);
     }
 
     /// <summary>
@@ -125,13 +131,13 @@ public static ReprocessingConfiguration Load(IConfiguration configuration, strin
       ArgumentValidator.EnsureArgumentNotNull(configuration, nameof(configuration));
 
       if (configuration is IConfigurationRoot configurationRoot) {
-        return new ReprocessingConfigurationReader().Read(configurationRoot, sectionName ?? ConfigurationSection.DefaultSectionName);
+        return new ReprocessingConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
       }
       else if (configuration is IConfigurationSection configurationSection) {
         return new ReprocessingConfigurationReader().Read(configurationSection);
       }
 
-      throw new NotSupportedException("Type of configuration is not supported");
+      throw new NotSupportedException("Type of configuration is not supported.");
     }
 
 
@@ -145,7 +151,7 @@ public static ReprocessingConfiguration Load(IConfigurationRoot configurationRoo
     {
       ArgumentValidator.EnsureArgumentNotNull(configurationRoot, nameof(configurationRoot));
 
-      return new ReprocessingConfigurationReader().Read(configurationRoot, sectionName ?? ConfigurationSection.DefaultSectionName);
+      return new ReprocessingConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
     }
 
     /// <summary>
@@ -160,8 +166,6 @@ public static ReprocessingConfiguration Load(IConfigurationSection configuration
       return new ReprocessingConfigurationReader().Read(configurationSection);
     }
 
-    
-
     /// <summary>
     /// Initializes a new instance of the <see cref="ReprocessingConfiguration"/> class.
     /// </summary>

Extensions/Xtensive.Orm.Reprocessing/Configuration/ReprocessingConfigurationReader.cs

@@ -1,4 +1,8 @@
-using System;
+// Copyright (C) 2024 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
+using System;
 using Microsoft.Extensions.Configuration;
 using Xtensive.Orm.Configuration;
 
@@ -20,7 +24,7 @@ public ReprocessingConfiguration Read(IConfigurationSection configurationSection
       throw new NotSupportedException();
 
     public ReprocessingConfiguration Read(IConfigurationRoot configurationRoot) =>
-      Read(configurationRoot, ConfigurationSection.DefaultSectionName);
+      Read(configurationRoot, ReprocessingConfiguration.DefaultSectionName);
 
     public ReprocessingConfiguration Read(IConfigurationRoot configurationRoot, string sectionName)
     {

Extensions/Xtensive.Orm.Reprocessing/DomainConfigurationExtensions.cs

@@ -1,3 +1,7 @@
+// Copyright (C) 2024 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
 using Microsoft.Extensions.Configuration;
 using Xtensive.Orm.Configuration;
 using Xtensive.Orm.Reprocessing.Configuration;

Extensions/Xtensive.Orm.Security/Configuration/SecurityConfiguration.cs

@@ -1,6 +1,6 @@
 // Copyright (C) 2011-2024 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.06.10
 
@@ -21,8 +21,7 @@ namespace Xtensive.Orm.Security.Configuration
   public class SecurityConfiguration : ConfigurationBase
   {
     /// <summary>
-    /// Default SectionName value:
-    /// "<see langword="Xtensive.Orm.Security" />".
+    /// Default section in configuration. Used if custom name is not provided.
     /// </summary>
     public const string DefaultSectionName = "Xtensive.Orm.Security";
 
@@ -119,14 +118,16 @@ private static SecurityConfiguration GetConfigurationFromSection(ConfigurationSe
       var hashingService = configurationSection == null
         ? string.Empty
         : configurationSection.HashingService.Name;
-      if (!string.IsNullOrEmpty(hashingService))
+      if (!string.IsNullOrEmpty(hashingService)) {
         result.HashingServiceName = hashingService.ToLowerInvariant();
+      }
 
       var authenticationService = configurationSection == null
         ? string.Empty
         : configurationSection.AuthenticationService.Name;
-      if (!string.IsNullOrEmpty(authenticationService))
+      if (!string.IsNullOrEmpty(authenticationService)) {
         result.AuthenticationServiceName = authenticationService.ToLowerInvariant();
+      }
 
       return result;
     }
@@ -148,7 +149,7 @@ public static SecurityConfiguration Load(IConfiguration configuration, string se
         return Load(configurationSection);
       }
 
-      throw new NotSupportedException("Type of configuration is not supported");
+      throw new NotSupportedException("Type of configuration is not supported.");
     }
 
 
@@ -163,13 +164,12 @@ public static SecurityConfiguration Load(IConfigurationRoot configurationRoot, s
       ArgumentValidator.EnsureArgumentNotNull(configurationRoot, nameof(configurationRoot));
 
       var configuration = new NamelessFormatSecurityConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
-      if (configuration != null)
+      if (configuration != null) {
         return configuration;
+      }
 
       configuration = new BasedOnNamesFormatSecurityConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
-      if (configuration != null)
-        return configuration;
-      return new SecurityConfiguration(true);
+      return configuration ?? new SecurityConfiguration(true);
     }
 
     /// <summary>
@@ -182,13 +182,12 @@ public static SecurityConfiguration Load(IConfigurationSection configurationSect
       ArgumentValidator.EnsureArgumentNotNull(configurationSection, nameof(configurationSection));
 
       var configuration = new NamelessFormatSecurityConfigurationReader().Read(configurationSection);
-      if (configuration != null)
+      if (configuration != null) {
         return configuration;
+      }
 
       configuration = new BasedOnNamesFormatSecurityConfigurationReader().Read(configurationSection);
-      if (configuration != null)
-        return configuration;
-      return new SecurityConfiguration(true);
+      return configuration ?? new SecurityConfiguration(true);
     }
 
     /// <summary>

Extensions/Xtensive.Orm.Security/Configuration/SecurityConfigurationReaders.cs

@@ -1,9 +1,11 @@
+// Copyright (C) 2024 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
+
 using System;
-using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using Microsoft.Extensions.Configuration;
+using Xtensive.Core;
 using Xtensive.Orm.Configuration;
 
 namespace Xtensive.Orm.Security.Configuration
@@ -12,16 +14,6 @@ internal sealed class NamelessFormatSecurityConfigurationReader : SecurityConfig
   {
     protected override SecurityConfiguration ReadInternal(IConfigurationSection configuration)
     {
-      //  <Xtensive.Orm.Security>
-      //    <hashingService>sha1</hashingService>
-      //    <authenticationService>SomeServiceName</authenticationService>
-      //  </Xtensive.Orm.Security>
-      // or
-      //  "Xtensive.Orm.Security" : {
-      //    "hashingService" :"sha1",
-      //    "authenticationService" : "SomeServiceName"
-      //  }
-
       try {
         var configAsIs = configuration.Get<SecurityConfiguration>();
         if (configAsIs != null && (configAsIs.AuthenticationServiceName ?? configAsIs.HashingServiceName) != null) {
@@ -38,13 +30,10 @@ protected override SecurityConfiguration ReadInternal(IConfigurationSection conf
         return null;
       }
 
-      var children = configuration.GetChildren().ToList();
-      if (!children.Any()) {
-        return new SecurityConfiguration(true);
-      }
-      else {
-        return null;
-      }
+      var children = configuration.GetChildren();
+      return !children.Any()
+        ? new SecurityConfiguration(true)
+        : null;
     }
   }
 
@@ -79,10 +68,13 @@ protected override SecurityConfiguration ReadInternal(IConfigurationSection conf
       }
       if ((hashingServiceName ?? authenticationServiceName) != null) {
         var securityConfiguration = new SecurityConfiguration(true);
-        if (!string.IsNullOrEmpty(hashingServiceName))
+        if (!hashingServiceName.IsNullOrEmpty()) {
           securityConfiguration.HashingServiceName = hashingServiceName.ToLowerInvariant();
-        if (!string.IsNullOrEmpty(authenticationServiceName))
+        }
+
+        if (!authenticationServiceName.IsNullOrEmpty()) {
           securityConfiguration.AuthenticationServiceName = authenticationServiceName.ToLowerInvariant();
+        }
 
         return securityConfiguration;
       }

Orm/Xtensive.Orm/Orm/Configuration/DomainConfiguration.cs

@@ -9,17 +9,15 @@
 using System.Linq;
 using JetBrains.Annotations;
 using Microsoft.Extensions.Configuration;
-using Xtensive.Collections;
 using Xtensive.Core;
-using Xtensive.Orm.Configuration.Internals;
 using Xtensive.Orm.Internals;
 using ConfigurationSection = Xtensive.Orm.Configuration.Elements.ConfigurationSection;
 
 namespace Xtensive.Orm.Configuration
 {
   /// <summary>
   /// The configuration of the <see cref="Domain"/>.
-  /// </summary> 
+  /// </summary>
   [Serializable]
   public class DomainConfiguration : ConfigurationBase
   {