Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue New Release #37

Closed
1 task done
ThomasThelen opened this issue May 18, 2020 · 3 comments
Closed
1 task done

Issue New Release #37

ThomasThelen opened this issue May 18, 2020 · 3 comments

Comments

@ThomasThelen
Copy link
Member

ThomasThelen commented May 18, 2020 •
edited
Loading

This issue is used to track the progress of the next d1_python release. @datadavev this should be fine to review.

Goals

The overall goals are to add support for adding file paths to the ORE.

Issues Resolved

Version Number

If there was only a bug fix, we could get away with a patch: 3.4.7 -> 3.4.8
Since there's also a new feature, I think (based on https://semver.org/) the new version should be 3.5.0
@rogerdahl might have stronger opinions on this.
@ThomasThelen ThomasThelen mentioned this issue Jul 6, 2020
Closed
@ThomasThelen
Copy link
Member Author

This has been completed!

@amoeba
Copy link

amoeba commented Oct 31, 2020

Glad to see this land, thanks @ThomasThelen. Should we also update the CHANGELOG.md and issue a release+tag on GitHub to match the 3.5.0 version on PyPi?

@ThomasThelen
Copy link
Member Author

@amoeba good catch! I put a topic in about this for the next dev call (historically I don't touch the versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amoeba @ThomasThelen