not sure whether this is right way? but builds and passes lint

Author: taegyunkim

Cargo.lock

@@ -27,7 +27,6 @@ build_common = { path = "../build-common" }
 [dependencies]
 anyhow = "1.0"
 chrono = {version = "0.4", default-features = false }
-crossbeam-queue = "0.3.11"
 datadog-crashtracker = { path = "../crashtracker" }
 datadog-profiling = { path = "../profiling" }
 hyper = { version = "0.14", default-features = false }

profiling-ffi/Cargo.toml

@@ -33,6 +33,11 @@ renaming_overrides_prefixing = true
 "Vec_Tag" = "ddog_Vec_Tag"
 "Vec_U8" = "ddog_Vec_U8"
 
+"ArrayQueueNewResult" = "ddog_prof_ArrayQueue_NewResult"
+"ArrayQueuePushResult" = "ddog_prof_ArrayQueue_PushResult"
+"ArrayQueuePopResult" = "ddog_prof_ArrayQueue_PopResult"
+"ArrayQueueIsEmptyResult" = "ddog_prof_ArrayQueue_IsEmptyResult"
+"ArrayQueueLenResult" = "ddog_prof_ArrayQueue_LenResult"
 "ProfilingEndpoint" = "ddog_prof_Endpoint"
 "ExporterNewResult" = "ddog_prof_Exporter_NewResult"
 "File" = "ddog_prof_Exporter_File"
@@ -57,5 +62,10 @@ must_use = "DDOG_CHECK_RETURN"
 
 [parse]
 parse_deps = true
-include = ["ddcommon", "ddcommon-ffi", "datadog-profiling", "datadog-crashtracker", "ux"]
-
+include = [
+    "ddcommon",
+    "ddcommon-ffi",
+    "datadog-profiling",
+    "datadog-crashtracker",
+    "ux",
+]

profiling-ffi/cbindgen.toml

@@ -1,18 +1,17 @@
 use anyhow::Context;
-use crossbeam_queue::ArrayQueue as CBArrayQueue;
+use datadog_profiling::internal;
 use ddcommon_ffi::Error;
 use std::ffi::c_void;
 
-#[allow(dead_code)]
 #[repr(C)]
 pub struct ArrayQueue {
-    inner: *mut CBArrayQueue<*mut c_void>,
+    pub inner: *mut internal::ArrayQueue,
 }
 
 impl ArrayQueue {
-    fn new(queue: CBArrayQueue<*mut c_void>) -> Self {
+    pub fn new(inner: internal::ArrayQueue) -> Self {
         Self {
-            inner: Box::into_raw(Box::new(queue)),
+            inner: Box::into_raw(Box::new(inner)),
         }
     }
 }
@@ -24,32 +23,16 @@ pub enum ArrayQueueNewResult {
     Err(Error),
 }
 
-#[allow(unused)]
-#[repr(C)]
-pub enum ArrayQueuePushResult {
-    Ok(bool),
-    Err(Error),
-}
-
-impl From<Result<(), anyhow::Error>> for ArrayQueuePushResult {
-    fn from(result: Result<(), anyhow::Error>) -> Self {
-        match result {
-            Ok(_) => ArrayQueuePushResult::Ok(true),
-            Err(err) => ArrayQueuePushResult::Err(err.into()),
-        }
-    }
-}
-
 #[no_mangle]
 pub unsafe extern "C" fn array_queue_new(capacity: usize) -> ArrayQueueNewResult {
-    let internal_queue = CBArrayQueue::new(capacity);
+    let internal_queue = internal::ArrayQueue::new(capacity);
     let ffi_queue = ArrayQueue::new(internal_queue);
     ArrayQueueNewResult::Ok(ffi_queue)
 }
 
 unsafe fn array_queue_ptr_to_inner<'a>(
     queue_ptr: *mut ArrayQueue,
-) -> anyhow::Result<&'a mut crossbeam_queue::ArrayQueue<*mut c_void>> {
+) -> anyhow::Result<&'a mut internal::ArrayQueue> {
     match queue_ptr.as_mut() {
         None => anyhow::bail!("queue_ptr is null"),
         Some(queue) => match queue.inner.as_mut() {
@@ -59,6 +42,22 @@ unsafe fn array_queue_ptr_to_inner<'a>(
     }
 }
 
+#[allow(unused)]
+#[repr(C)]
+pub enum ArrayQueuePushResult {
+    Ok(bool),
+    Err(Error),
+}
+
+impl From<Result<(), anyhow::Error>> for ArrayQueuePushResult {
+    fn from(result: Result<(), anyhow::Error>) -> Self {
+        match result {
+            Ok(_) => ArrayQueuePushResult::Ok(true),
+            Err(err) => ArrayQueuePushResult::Err(err.into()),
+        }
+    }
+}
+
 #[no_mangle]
 pub unsafe extern "C" fn array_queue_push(
     queue_ptr: *mut ArrayQueue,

profiling-ffi/src/array_queue.rs

@@ -22,6 +22,7 @@ anyhow = "1.0"
 bitmaps = "3.2.0"
 bytes = "1.1"
 chrono = {version = "0.4", default-features = false, features = ["std", "clock"]}
+crossbeam-queue = "0.3.11"
 datadog-alloc = {path = "../alloc"}
 ddcommon = {path = "../ddcommon"}
 derivative = "2.2.0"

profiling/Cargo.toml

@@ -0,0 +1,35 @@
+use std::ffi::c_void;
+
+#[derive(Debug)]
+#[allow(unused)]
+pub struct ArrayQueue {
+    inner: crossbeam_queue::ArrayQueue<*mut c_void>,
+}
+
+impl ArrayQueue {
+    #[allow(unused)]
+    pub fn new(capacity: usize) -> Self {
+        Self {
+            inner: crossbeam_queue::ArrayQueue::new(capacity),
+        }
+    }
+
+    #[allow(unused)]
+    pub fn push(&self, value: *mut c_void) -> Result<(), *mut c_void> {
+        self.inner.push(value)
+    }
+
+    #[allow(unused)]
+    pub fn pop(&self) -> Option<*mut c_void> {
+        self.inner.pop()
+    }
+
+    #[allow(unused)]
+    pub fn is_empty(&self) -> bool {
+        self.inner.is_empty()
+    }
+
+    pub fn len(&self) -> usize {
+        self.inner.len()
+    }
+}

profiling/src/internal/array_queue.rs

@@ -1,6 +1,7 @@
 // Copyright 2023-Present Datadog, Inc. https://www.datadoghq.com/
 // SPDX-License-Identifier: Apache-2.0
 
+mod array_queue;
 mod endpoint_stats;
 mod endpoints;
 mod function;
@@ -16,6 +17,7 @@ mod timestamp;
 mod upscaling;
 mod value_type;
 
+pub use array_queue::*;
 pub use endpoint_stats::*;
 pub use endpoints::*;
 pub use function::*;